-
Notifications
You must be signed in to change notification settings - Fork 6
WMSDK-494: Add common sdk #611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request integrates the common SDK into the codebase according to WMSDK-494 by updating import paths, replacing custom implementations with common SDK methods, and removing obsolete classes and interfaces.
- Updated imports to use cloud.mindbox.common, including parseTimeSpanToMillis and MindboxCommon.VERSION.
- Replaced direct instantiation of CustomerAbMixerImpl with factory method CustomerAbMixer.impl().
- Removed outdated implementation files (CustomerAbMixerImpl and CustomerAbMixer interface) and updated build files to include the common SDK dependency.
Reviewed Changes
Copilot reviewed 16 out of 17 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
sdk/src/test/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogicTest.kt | Added updated import for CustomerAbMixer. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/abtests/CustomerAbMixerTest.kt | Updated usage of CustomerAbMixer to use the new factory method. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/ParseTimeSpanTest.kt | Updated import for parseTimeSpanToMillis from the common SDK. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/managers/MobileConfigSettingsManagerImpl.kt | Replaced outdated import with one from the common SDK. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/validators/TtlParametersValidator.kt | Updated import reference to the common SDK. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/validators/TimeSpanPositiveValidator.kt | Updated import reference to the common SDK. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/inapp/data/validators/InAppConfigTtlValidator.kt | Updated import reference to the common SDK. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/di/modules/MindboxModule.kt | Updated import for CustomerAbMixer from the new package. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/di/modules/DomainModule.kt | Replaced instantiation of CustomerAbMixer with the new factory method. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/InAppABTestLogic.kt | Added updated import for CustomerAbMixer. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/CustomerAbMixerImpl.kt | Removed obsolete implementation in favor of the common SDK approach. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/abtests/CustomerAbMixer.kt | Removed obsolete interface definition. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/Mindbox.kt | Updated logging to include the Common SDK version and added necessary imports. |
sdk/src/main/java/cloud/mindbox/mobile_sdk/Extensions.kt | Removed custom parseTimeSpanToMillis extension now provided by the common SDK. |
sdk/build.gradle | Added dependency on the common SDK. |
gradle/libs.versions.toml | Added configuration for the mindbox_common dependency. |
sdk/src/test/java/cloud/mindbox/mobile_sdk/ParseTimeSpanTest.kt
Outdated
Show resolved
Hide resolved
sdk/src/main/java/cloud/mindbox/mobile_sdk/di/modules/MindboxModule.kt
Outdated
Show resolved
Hide resolved
a71aeac
to
1a6edf1
Compare
cfad061
to
c57e208
Compare
https://tracker.yandex.ru/WMSDK-494