Skip to content

fix(PropertyFactory): 加载的 properties 文件不存在报错 #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

fix(PropertyFactory): 加载的 properties 文件不存在报错 #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/main/java/org/minbox/framework/sequence/leaf/common/PropertyFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,12 @@
import org.slf4j.LoggerFactory;

import java.io.IOException;
import java.io.InputStream;
import java.util.Properties;

/**
* 加载 leaf.properties
*/
public class PropertyFactory {

private static final Logger logger = LoggerFactory.getLogger(PropertyFactory.class);
Expand All @@ -18,8 +22,10 @@ public static void setLeafName(String leafName){
}

static {
try {
prop.load(PropertyFactory.class.getClassLoader().getResourceAsStream("leaf.properties"));
try (InputStream resourceAsStream = PropertyFactory.class.getClassLoader().getResourceAsStream("leaf.properties")) {
if (resourceAsStream != null) {
prop.load(resourceAsStream);
}
} catch (IOException e) {
logger.warn("Load Properties Ex", e);
}
Expand Down
18 changes: 12 additions & 6 deletions src/test/java/org/minbox/framework/sequence/id/leaf/SnowflakeIDGenImplTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,25 @@
import org.minbox.framework.sequence.leaf.exception.InitException;
import org.minbox.framework.sequence.leaf.facade.LeafSnowflakeSequenceGen;

import java.util.Properties;

public class SnowflakeIDGenImplTest {
@Test
public void testGetId() throws InitException {
Properties properties = PropertyFactory.getProperties();
PropertyFactory.setLeafName(properties.getProperty("snawflake.name"));
LeafSnowflakeSequenceGen sequenceGen = new LeafSnowflakeSequenceGen(properties.getProperty("zk.list")
, Integer.parseInt(properties.getProperty("snowflake.port")));
// Properties properties = PropertyFactory.getProperties();
// PropertyFactory.setLeafName(properties.getProperty("snawflake.name"));
LeafSnowflakeSequenceGen sequenceGen = new LeafSnowflakeSequenceGen("dev-zk.lls.com:2181"
, 8688);
for (int i = 1; i < 1000; ++i) {
long a = sequenceGen.get("a");
System.out.println(a);
}

}

/**
* 当 properties 文件不存在的时候防止启动报错
*/
@Test
public void testProperties() {
PropertyFactory.getProperties().getProperty("ss");
}
}