Merge pull request neurony#12 from 23G/revision-timestamps

Allow for revisions to contain timestamps
minasm · Apr 16, 2019 · 1d6af05 · 1d6af05
2 parents 41bbfec + 9a4d037
commit 1d6af05
Show file tree

Hide file tree

Showing 3 changed files with 39 additions and 1 deletion.
diff --git a/src/Options/RevisionOptions.php b/src/Options/RevisionOptions.php
@@ -55,6 +55,13 @@ class RevisionOptions
      */
     private $createRevisionWhenRollingBack = true;
 
+    /**
+     * Flag indicating whether to include timestamps in the revision.
+     *
+     * @var bool
+     */
+    private $revisionTimestamps = false;
+
     /**
      * Get the value of a property of this class.
      *
@@ -158,4 +165,16 @@ public function disableRevisioningWhenRollingBack(): self
 
         return $this;
     }
+
+    /**
+     * Enable the revisioning of timestamps.
+     *
+     * @return $this
+     */
+    public function withTimestamps()
+    {
+        $this->revisionTimestamps = true;
+
+        return $this;
+    }
 }
diff --git a/src/Traits/SaveRevisionJsonRepresentation.php b/src/Traits/SaveRevisionJsonRepresentation.php
@@ -49,7 +49,7 @@ protected function buildRevisionDataFromModel(): array
 
         unset($data[$this->getKeyName()]);
 
-        if ($this->usesTimestamps()) {
+        if ($this->usesTimestamps() && !$this->revisionOptions->revisionTimestamps) {
             unset($data[$this->getCreatedAtColumn()]);
             unset($data[$this->getUpdatedAtColumn()]);
         }

diff --git a/tests/HasRevisionsTest.php b/tests/HasRevisionsTest.php
@@ -193,6 +193,25 @@ public function getRevisionOptions() : RevisionOptions
         $this->assertArrayHasKey('views', $revision->metadata);
     }
 
+    /** @test */
+    public function it_can_include_timestamps_when_creating_a_revision()
+    {
+        $model = new class extends Post {
+            public function getRevisionOptions() : RevisionOptions
+            {
+                return parent::getRevisionOptions()->withTimestamps();
+            }
+        };
+
+        $this->makeModels($model);
+        $this->modifyPost();
+
+        $revision = $this->post->revisions()->first();
+
+        $this->assertArrayHasKey('created_at', $revision->metadata);
+        $this->assertArrayHasKey('updated_at', $revision->metadata);
+    }
+
     /** @test */
     public function it_can_save_belongs_to_relations_when_creating_a_revision()
     {