Use golangci-lint instead of golint #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have been using golint as a linter, but golint was officially deprecated. golang/go#38968 The revive is a drop-in replacement of golint. https://github.com/mgechev/revive It's possible to use revive as it is, but I'd like to use revive via golangci-lint so that we can add more linters easily. https://github.com/golangci/golangci-lint The golangci-lint is a meta linter. I'll take this opportunity to introduce some additional checks.
I'll fix them following PRs.
minamijoyo
force-pushed
the
use-golangci-instead-of-golint
branch
from
13cb3a9
to
13cbc5f
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been using golint as a linter, but golint was officially deprecated.
golang/go#38968
The revive is a drop-in replacement of golint.
https://github.com/mgechev/revive
It's possible to use revive as it is, but I'd like to use revive via golangci-lint so that we can add more linters easily.
https://github.com/golangci/golangci-lint
The golangci-lint is a meta linter. I'll take this opportunity to introduce some additional checks.
I've suppressed all existing lint errors to pass CI. I'll fix them following PRs.