Continue to plan to_dir for multi_state if force is true #139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minamijoyo
approved these changes
Jun 12, 2023
|
I'm waiting for Terraform v1.5 reaches to GA before I cut a new release of tfmigrate, but even if it doesn't come soon, I will cut a new release in a week or so. |
|
tfmigrate v0.3.12 has been released. |
minamijoyo
added a commit
that referenced
this pull request
Aug 3, 2023
Fixes #140 We slightly fixed the behavior of the force option in #139, but the fix introduced a regression in error handling; errors in plan commands, except for detected diffs, should not be ignored regardless of force or not. A single-state migration implementation did not have this bug because it had a similar but different implementation, but I'll take this opportunity to use the same logic.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
In
multi_statemode,from_dirwill be planned first before planning theto_dir. Whenforce = trueand there are unexpected diffs for thefrom_dir, the check for theto_dirwill be skipped.If
to_dircheck is skipped in this case, we wont be able to confirm any unexpected changes.This PR addresses this issue by ensuring that both
from_dirandto_dirwill be checked.How
If
force = trueand there are unexpected diffs in thefrom_dirplan check, instead of returning the function immediately, continue to checkto_dir.