Unskipped tests for Windows (ray-project#21702)

This set of tests passes without issues on Windows for me, so unskipping them here.

python/ray/serve/tests/test_failure.py

@@ -143,7 +143,6 @@ def __call__(self, *args):
 
 # Test that if there are multiple replicas for a worker and one dies
 # unexpectedly, the others continue to serve requests.
-@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
 def test_worker_replica_failure(serve_instance):
     @ray.remote
     class Counter:

python/ray/tests/BUILD

@@ -144,6 +144,9 @@ py_test_module_list(
     "test_unhandled_error.py",
     "test_top_level_api.py",
     "test_list_actors.py",
+    "test_list_actors_2.py",
+    "test_list_actors_3.py",
+    "test_list_actors_4.py",
     "test_usage_stats.py",
   ],
   size = "small",
@@ -342,6 +345,9 @@ py_test_module_list(
     "test_asyncio.py",
     "test_multiprocessing.py",
     "test_list_actors.py",
+    "test_list_actors_2.py",
+    "test_list_actors_3.py",
+    "test_list_actors_4.py",
   ],
   size = "medium",
   extra_srcs = SRCS,

python/ray/tests/test_client_terminate.py

@@ -135,7 +135,7 @@ def mock_terminate(self, term):
 
 
 if __name__ == "__main__":
-    import sys
     import pytest
+    import sys
 
     sys.exit(pytest.main(["-v", __file__]))

python/ray/tests/test_iter.py

@@ -286,7 +286,6 @@ def test_filter(ray_start_regular_shared):
     assert list(it.gather_sync()) == [0, 2, 1]
 
 
-@pytest.mark.skipif(sys.platform == "win32", reason="Failing on Windows.")
 def test_local_shuffle(ray_start_regular_shared):
     # confirm that no data disappears, and they all stay within the same shard
     it = from_range(8, num_shards=2).local_shuffle(shuffle_buffer_size=2)
@@ -561,6 +560,4 @@ def get(it):
 
 
 if __name__ == "__main__":
-    import sys
-
     sys.exit(pytest.main(["-v", __file__]))

python/ray/tests/test_list_actors.py

@@ -1,9 +1,8 @@
-import os
 import pytest
 import sys
 
 import ray
-from ray._private.test_utils import run_string_as_driver, wait_for_condition
+from ray._private.test_utils import wait_for_condition
 
 
 def test_list_named_actors_basic(ray_start_regular):
@@ -53,112 +52,6 @@ class A:
     assert "hi2" in ray.util.list_named_actors()
 
 
-@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on Windows.")
-def test_list_named_actors_restarting_actor(ray_start_regular):
-    @ray.remote(max_restarts=-1)
-    class A:
-        def __init__(self):
-            os._exit(0)
-
-    a = A.options(name="hi").remote()
-    for _ in range(10000):
-        assert ray.util.list_named_actors() == ["hi"]
-
-    del a
-    wait_for_condition(lambda: not ray.util.list_named_actors())
-
-
-def test_list_named_actors_ray_kill(ray_start_regular):
-    """Verify that names are returned even while actors are restarting."""
-
-    @ray.remote(max_restarts=-1)
-    class A:
-        def __init__(self):
-            pass
-
-    a = A.options(name="hi").remote()
-    assert ray.util.list_named_actors() == ["hi"]
-    ray.kill(a, no_restart=False)
-    assert ray.util.list_named_actors() == ["hi"]
-    ray.kill(a, no_restart=True)
-    assert not ray.util.list_named_actors()
-
-
-def test_list_named_actors_detached(ray_start_regular):
-    """Verify that names are returned for detached actors until killed."""
-    address = ray_start_regular["address"]
-
-    driver_script = """
-import ray
-ray.init(address="{}", namespace="default_test_namespace")
-
-@ray.remote
-class A:
-    pass
-
-A.options(name="hi", lifetime="detached").remote()
-a = A.options(name="sad").remote()
-
-assert len(ray.util.list_named_actors()) == 2
-assert "hi" in ray.util.list_named_actors()
-assert "sad" in ray.util.list_named_actors()
-""".format(
-        address
-    )
-
-    run_string_as_driver(driver_script)
-
-    assert ray.util.list_named_actors() == ["hi"]
-
-
-@pytest.mark.skipif(sys.platform == "win32", reason="Flaky on Windows.")
-def test_list_named_actors_namespace(ray_start_regular):
-    """Verify that actor names are filtered on namespace by default."""
-    address = ray_start_regular["address"]
-
-    driver_script_1 = """
-import ray
-ray.init(address="{}", namespace="test")
-
-@ray.remote
-class A:
-    pass
-
-A.options(name="hi", lifetime="detached").remote()
-
-assert len(ray.util.list_named_actors()) == 1
-assert ray.util.list_named_actors() == ["hi"]
-assert ray.util.list_named_actors(all_namespaces=True) == \
-    [dict(name="hi", namespace="test")]
-""".format(
-        address
-    )
-
-    run_string_as_driver(driver_script_1)
-
-    assert not ray.util.list_named_actors()
-    assert ray.util.list_named_actors(all_namespaces=True) == [
-        {"name": "hi", "namespace": "test"}
-    ]
-
-    driver_script_2 = """
-import ray
-ray.init(address="{}", namespace="test")
-
-assert ray.util.list_named_actors() == ["hi"]
-assert ray.util.list_named_actors(all_namespaces=True) == \
-    [dict(name="hi", namespace="test")]
-ray.kill(ray.get_actor("hi"), no_restart=True)
-assert not ray.util.list_named_actors()
-""".format(
-        address
-    )
-
-    run_string_as_driver(driver_script_2)
-    assert not ray.util.list_named_actors()
-    assert not ray.util.list_named_actors(all_namespaces=True)
-
-
 if __name__ == "__main__":
     # Test suite is timing out. Disable on windows for now.
     sys.exit(pytest.main(["-v", __file__]))

python/ray/tests/test_list_actors_2.py

@@ -0,0 +1,25 @@
+import os
+import pytest
+import sys
+
+import ray
+from ray._private.test_utils import wait_for_condition
+
+
+def test_list_named_actors_restarting_actor(ray_start_regular):
+    @ray.remote(max_restarts=-1)
+    class A:
+        def __init__(self):
+            os._exit(0)
+
+    a = A.options(name="hi").remote()
+    for _ in range(10000):
+        assert ray.util.list_named_actors() == ["hi"]
+
+    del a
+    wait_for_condition(lambda: not ray.util.list_named_actors())
+
+
+if __name__ == "__main__":
+    # Test suite is timing out. Disable on windows for now.
+    sys.exit(pytest.main(["-v", __file__]))

python/ray/tests/test_list_actors_3.py

@@ -0,0 +1,53 @@
+import pytest
+import sys
+
+import ray
+from ray._private.test_utils import run_string_as_driver
+
+
+def test_list_named_actors_ray_kill(ray_start_regular):
+    """Verify that names are returned even while actors are restarting."""
+
+    @ray.remote(max_restarts=-1)
+    class A:
+        def __init__(self):
+            pass
+
+    a = A.options(name="hi").remote()
+    assert ray.util.list_named_actors() == ["hi"]
+    ray.kill(a, no_restart=False)
+    assert ray.util.list_named_actors() == ["hi"]
+    ray.kill(a, no_restart=True)
+    assert not ray.util.list_named_actors()
+
+
+def test_list_named_actors_detached(ray_start_regular):
+    """Verify that names are returned for detached actors until killed."""
+    address = ray_start_regular["address"]
+
+    driver_script = """
+import ray
+ray.init(address="{}", namespace="default_test_namespace")
+
+@ray.remote
+class A:
+    pass
+
+A.options(name="hi", lifetime="detached").remote()
+a = A.options(name="sad").remote()
+
+assert len(ray.util.list_named_actors()) == 2
+assert "hi" in ray.util.list_named_actors()
+assert "sad" in ray.util.list_named_actors()
+""".format(
+        address
+    )
+
+    run_string_as_driver(driver_script)
+
+    assert ray.util.list_named_actors() == ["hi"]
+
+
+if __name__ == "__main__":
+    # Test suite is timing out. Disable on windows for now.
+    sys.exit(pytest.main(["-v", __file__]))

python/ray/tests/test_list_actors_4.py

@@ -0,0 +1,57 @@
+import pytest
+import sys
+
+import ray
+from ray._private.test_utils import run_string_as_driver
+
+
+def test_list_named_actors_namespace(ray_start_regular):
+    """Verify that actor names are filtered on namespace by default."""
+    address = ray_start_regular["address"]
+
+    driver_script_1 = """
+import ray
+ray.init(address="{}", namespace="test")
+
+@ray.remote
+class A:
+    pass
+
+A.options(name="hi", lifetime="detached").remote()
+
+assert len(ray.util.list_named_actors()) == 1
+assert ray.util.list_named_actors() == ["hi"]
+assert ray.util.list_named_actors(all_namespaces=True) == \
+    [dict(name="hi", namespace="test")]
+""".format(
+        address
+    )
+
+    run_string_as_driver(driver_script_1)
+
+    assert not ray.util.list_named_actors()
+    assert ray.util.list_named_actors(all_namespaces=True) == [
+        {"name": "hi", "namespace": "test"}
+    ]
+
+    driver_script_2 = """
+import ray
+ray.init(address="{}", namespace="test")
+
+assert ray.util.list_named_actors() == ["hi"]
+assert ray.util.list_named_actors(all_namespaces=True) == \
+    [dict(name="hi", namespace="test")]
+ray.kill(ray.get_actor("hi"), no_restart=True)
+assert not ray.util.list_named_actors()
+""".format(
+        address
+    )
+
+    run_string_as_driver(driver_script_2)
+    assert not ray.util.list_named_actors()
+    assert not ray.util.list_named_actors(all_namespaces=True)
+
+
+if __name__ == "__main__":
+    # Test suite is timing out. Disable on windows for now.
+    sys.exit(pytest.main(["-v", __file__]))