Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use :when as :enable-funcion in tempel-abbrev-mode #149

Merged
merged 2 commits into from
Dec 4, 2024

Conversation

Ursus-GIT5805
Copy link
Contributor

This is my feature request as discussed in #147.
Just let me know if there is something you don't like.

@minad
Copy link
Owner

minad commented Oct 22, 2024

I think we don't need the :when/:enable-function duplication. In the context of abbrev :when should probably have the effect of an :enable-function?

Did you assign copyright to the FSF? I need your name to confirm, but you can also sent this to my in private via mail. See https://github.com/minad/tempel?tab=readme-ov-file#contributions.

@Ursus-GIT5805
Copy link
Contributor Author

You're correct, using :enable-function is overly complicated.
I changed it so :when is also used for the abbrev-expansion.
For the copyright assignment, I sent you a mail.

@Ursus-GIT5805 Ursus-GIT5805 changed the title Added feature: :enable-function Use :when as :enable-funcion in tempel-abbrev-mode Oct 29, 2024
@minad
Copy link
Owner

minad commented Nov 15, 2024

@Ursus-GIT5805 Has there been progress regarding the FSF assignment?

@Ursus-GIT5805
Copy link
Contributor Author

I finally got the message that the deputy director will sign the contract (hopefully soon). We just have to have a little patience...

@Ursus-GIT5805
Copy link
Contributor Author

Hey there,
The process is finally complete.

@minad minad merged commit 17d3f2c into minad:main Dec 4, 2024
minad added a commit that referenced this pull request Dec 4, 2024
@minad
Copy link
Owner

minad commented Dec 4, 2024

Thanks. I tested this for a while and in the end I went with a simpler version: 22f9348

One problem in your patch was that it changed the API of tempel-template-sources.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants