consult--async-split: do not insert initial split char if the minibuffer already starts with it #1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fer already starts with it When running vertico-repeat-previous, vertico will clear the minibuffer and then insert the text that was saved in history (e.g. "#some-text"). Later, when consult--async-split tries to inser the split char in the minibuffer, the restored session has "##some-text" as input -- which does not search for anything. This commit fixes the issue by checking the minibuffer contents before inserting the initial split char.
|
Thanks! I pushed a slightly different fix. |
|
Awesome! The fix worked fine here for me! Closing this. Thanks @minad ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running vertico-repeat-previous, vertico will clear the minibuffer and then insert the text that was saved in history (e.g. "#some-text").
Later, when consult--async-split tries to insert the split char, the restored session ends up with "##some-text" as input -- which does not search for anything.
This commit fixes the issue by checking the minibuffer contents before inserting the initial split char.