Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse task string to reenable task #189

Merged
merged 1 commit into from
May 14, 2014

Conversation

PChambino
Copy link
Contributor

I noticed that when using the invoke helper and the reenable option with a task with arguments it fails to lookup the task.

I added a failing test and used the parse_task_string method to get the task name without the arguments in order to reenable the task.

gabskoro added a commit that referenced this pull request May 14, 2014
@gabskoro gabskoro merged commit 835ea2f into mina-deploy:master May 14, 2014
@raphox
Copy link

raphox commented Jun 6, 2014

Hi!

I tried to use the helper to reenable, but my task possesses paramentes and could not use. See the example:

  invoke :"load_server[#{name}]", reenable: true

  Error:
    deployer aborted!
    Don't know how to build task 'load_server[development]'

Only works:

  Rake::Task[:load_server].reenable
  invoke :"load_server[#{name}]"

@PChambino
Copy link
Contributor Author

Are you using the latest version from the master branch?
Ensure that your Gemfile has gem 'mina', github: 'nadarei/mina' and run bundle update mina.

@gabskoro
Copy link
Member

gabskoro commented Jun 9, 2014

We will release a new version as soon we close all pull requests, until than pull mina from github.

@raphox
Copy link

raphox commented Jun 9, 2014

Yes, I'm using the last version:

$ bundle update
Updating git://github.com/nadarei/mina.git
Resolving dependencies...
Using rake 10.1.0
Using open4 1.3.3
Using mina 0.3.0 from git://github.com/nadarei/mina.git (at master)
Using bundler 1.6.2
Your bundle is updated!

My method 'invoke' has params 'reenable', but works only using rake without params. When I use rake with params, the executation generate the error:

Error:
    deployer aborted!
    Don't know how to build task 'load_server[development]'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants