Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment for GetSegementStates for Datacoord in types #9132

Merged
merged 1 commit into from
Oct 3, 2021

Conversation

congqixia
Copy link
Contributor

@congqixia congqixia commented Oct 3, 2021

See also #8640
/kind improvement
Signed-off-by: Congqi Xia congqi.xia@zilliz.com

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added kind/improvement Changes related to something improve, likes ut and code refactor size/S Denotes a PR that changes 10-29 lines. labels Oct 3, 2021
@codecov
Copy link

codecov bot commented Oct 3, 2021

Codecov Report

Merging #9132 (480d703) into master (9e2dfb8) will decrease coverage by 0.20%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9132      +/-   ##
==========================================
- Coverage   80.33%   80.12%   -0.21%     
==========================================
  Files         248      248              
  Lines       45499    45499              
==========================================
- Hits        36553    36458      -95     
- Misses       6848     6982     +134     
+ Partials     2098     2059      -39     
Impacted Files Coverage Δ
internal/distributed/indexcoord/param_table.go 85.71% <ø> (ø)
internal/distributed/indexcoord/service.go 68.96% <ø> (ø)
internal/distributed/indexnode/client/client.go 87.20% <ø> (ø)
internal/indexcoord/priority_queue.go 79.74% <ø> (ø)
internal/indexnode/indexnode.go 89.95% <ø> (ø)
internal/indexnode/task_scheduler.go 90.20% <ø> (ø)
internal/querycoord/param_table.go 66.66% <ø> (ø)
internal/querynode/collection.go 97.70% <ø> (ø)
internal/storage/binlog_reader.go 88.46% <ø> (ø)
internal/util/dablooms/dablooms.go 81.25% <ø> (ø)
... and 40 more

@mergify mergify bot added the ci-passed label Oct 3, 2021
@wxyucs
Copy link
Member

wxyucs commented Oct 3, 2021

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, scsven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f8928fe into milvus-io:master Oct 3, 2021
@congqixia congqixia deleted the types_dc_getsegstates branch October 19, 2021 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants