Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add push mode for prometheus monitor #905

Merged
merged 6 commits into from
Jan 6, 2020
Merged

Add push mode for prometheus monitor #905

merged 6 commits into from
Jan 6, 2020

Conversation

fishpenguin
Copy link
Contributor

@fishpenguin fishpenguin requested a review from cydrain January 3, 2020 11:07
@codecov
Copy link

codecov bot commented Jan 4, 2020

Codecov Report

Merging #905 into master will decrease coverage by 0.03%.
The diff coverage is 78.57%.

@@            Coverage Diff             @@
##           master     #905      +/-   ##
==========================================
- Coverage   88.57%   88.54%   -0.04%     
==========================================
  Files         308      296      -12     
  Lines       13335    13164     -171     
==========================================
- Hits        11812    11656     -156     
+ Misses       1523     1508      -15
Impacted Files Coverage Δ
core/src/server/Config.h 100% <ø> (ø) ⬆️
core/src/metrics/prometheus/PrometheusMetrics.h 87% <0%> (-1.4%) ⬇️
core/src/db/DBImpl.cpp 86.61% <100%> (-1.44%) ⬇️
core/unittest/server/test_config.cpp 100% <100%> (ø) ⬆️
core/src/server/Config.cpp 83.25% <86.66%> (-9.83%) ⬇️
core/src/wrapper/WrapperException.h 0% <0%> (-100%) ⬇️
core/src/wrapper/WrapperException.cpp 0% <0%> (-100%) ⬇️
core/src/scheduler/job/BuildIndexJob.h 50% <0%> (-50%) ⬇️
core/src/scheduler/optimizer/FallbackPass.cpp 66.66% <0%> (-33.34%) ⬇️
core/src/utils/Exception.h 75% <0%> (-25%) ⬇️
... and 33 more

@JinHai-CN JinHai-CN merged commit a92a43e into milvus-io:master Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants