Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[skip ci] Update comment for drop alias #8916

Merged
merged 1 commit into from
Sep 30, 2021
Merged

[skip ci] Update comment for drop alias #8916

merged 1 commit into from
Sep 30, 2021

Conversation

cydrain
Copy link
Contributor

@cydrain cydrain commented Sep 30, 2021

Signed-off-by: yudong.cai yudong.cai@zilliz.com
Issue: #8640

@cydrain
[skip ci] Update comment for drop alias
7746197 
Signed-off-by: yudong.cai <yudong.cai@zilliz.com>
@cydrain
Copy link
Contributor Author

cydrain commented Sep 30, 2021

/kind improvement
/hold

@sre-ci-robot sre-ci-robot added do-not-merge/hold kind/improvement Changes related to something improve, likes ut and code refactor size/XS Denotes a PR that changes 0-9 lines. labels Sep 30, 2021
@mergify mergify bot added the ci-passed label Sep 30, 2021
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: cydrain
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

congqixia
congqixia approved these changes Sep 30, 2021
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@wxyucs
Copy link
Member

wxyucs commented Sep 30, 2021

/approve

@cydrain
Copy link
Contributor Author

cydrain commented Sep 30, 2021

/unhold

@sre-ci-robot sre-ci-robot merged commit 274913f into milvus-io:master Sep 30, 2021
@cydrain cydrain deleted the caiyd_102_comment_drop_alias branch September 30, 2021 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@xige-16 xige-16 Awaiting requested review from xige-16

@zwd1208 zwd1208 Awaiting requested review from zwd1208

Assignees

@congqixia congqixia

Labels
approved ci-passed kind/improvement Changes related to something improve, likes ut and code refactor lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@cydrain @sre-ci-robot @wxyucs @congqixia