[skip ci] knowhere detail design #6519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
|
/cc @xiaofan-luan |
|
@shengjun1985 Please associate the related issue to the body of your Pull Request. (eg. “issue: #5”) |
xiaofan-luan
requested changes
Aug 21, 2021
added 2 commits
August 23, 2021 10:24
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
Signed-off-by: shengjun.li <shengjun.li@zilliz.com>
|
Sorry but I didn't understand the command. Please consult the commands documentation 📚. Hey, I reacted but my real name is @Mergifyio |
shengjun1985
force-pushed
the
knowhere_design
branch
from
c99115a to
cd44b3b
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: shengjun1985, xiaofan-luan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add knowhere detail design
Resolves: #6544
Signed-off-by: shengjun.li shengjun.li@zilliz.com