Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md and DEVELOPMENT.md #6173

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Update README.md and DEVELOPMENT.md #6173

merged 1 commit into from
Jun 28, 2021

Conversation

jeffoverflow
Copy link
Contributor

Signed-off-by: quicksilver zhifeng.zhang@zilliz.com

/cc @scsven @xiaofan-luan

@jeffoverflow jeffoverflow requested a review from wxyucs June 28, 2021 07:43
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jun 28, 2021
@wxyucs
Copy link
Member

wxyucs commented Jun 28, 2021

/cc @PahudPlus
Please review the changes in README.md

@sre-ci-robot sre-ci-robot requested a review from PahudPlus June 28, 2021 07:46
@wxyucs
Copy link
Member

wxyucs commented Jun 28, 2021

The changes in DEVELOPMENT.md looks good to me.

PahudPlus
PahudPlus suggested changes Jun 28, 2021
View reviewed changes
README.md Outdated
# Compile Milvus Cluster.
$ make milvus
```
For the full story, head over to the [developer's documentation](https://github.com/milvus-io/milvus/blob/master/DEVELOPMENT.md).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

head over to --> see

PahudPlus
PahudPlus approved these changes Jun 28, 2021
View reviewed changes
Copy link
Contributor

@PahudPlus PahudPlus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

@PahudPlus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jeffoverflow
[skip ci] Update README.md and DEVELOPMENT.md
d877892 
Signed-off-by: quicksilver <zhifeng.zhang@zilliz.com>
@PahudPlus
Copy link
Contributor

/lgtm

@sre-ci-robot
Copy link
Contributor

@PahudPlus: changing LGTM is restricted to collaborators

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jeffoverflow, PahudPlus

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2834c85 into milvus-io:master Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PahudPlus PahudPlus PahudPlus approved these changes

@wxyucs wxyucs Awaiting requested review from wxyucs

@xiaofan-luan xiaofan-luan Awaiting requested review from xiaofan-luan

Assignees
No one assigned
Labels
approved ci-passed lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jeffoverflow @wxyucs @sre-ci-robot @PahudPlus