Skip to content

test: [cp2.6]refactor connection method to prioritize uri/token and add query limit #45948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

test: [cp2.6]refactor connection method to prioritize uri/token and add query limit #45948

wants to merge 1 commit into from

Conversation

@zhuwenxing
Copy link
Contributor

@zhuwenxing zhuwenxing commented Nov 28, 2025 •
edited
Loading

master pr: #45901

@zhuwenxing
test: refactor connection method to prioritize uri/token and add quer…
d5e7a29 
…y limit

- Refactor connection logic to prioritize uri and token parameters
  over host/port/user/password for a more modern connection approach
- Add explicit limit parameter (limit=5) to search and query operations
  in chaos checkers to avoid returning unlimited results
- Migrate test_all_collections_after_chaos.py from Collection wrapper
  to MilvusClient API style
- Update pytest fixtures in chaos test files to support uri/token params

Signed-off-by: zhuwenxing <wenxing.zhu@zilliz.com>
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 28, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhuwenxing
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added area/test sig/testing size/L Denotes a PR that changes 100-499 lines. labels Nov 28, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Nov 28, 2025
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@zhuwenxing Please associate the related pr of master to the body of your Pull Request. (eg. "pr: #")

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 28, 2025

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@sre-ci-robot sre-ci-robot added do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 28, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 28, 2025

[INFO] PR Label Summary by Default
[WARNING] No dependent PR reference found

  • Target branch '2.6' requires a PR merged to master first
  • Please add reference in format 'pr: #number'

[WARNING] Milestone not set

You can set milestone by commenting:
/set-milestone
Example:
/set-milestone 2.5.0

Use /refresh-label to update related check and label manually

@zhuwenxing zhuwenxing added this to the 2.6.7 milestone Nov 28, 2025
@zhuwenxing
Copy link
Contributor Author

zhuwenxing commented Nov 28, 2025

/refresh-label

@sre-ci-robot sre-ci-robot removed do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first do-not-merge/need-milestone generate by v2-label-manager labels Nov 28, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 28, 2025

[INFO] PR Label Summary by Refresh-Label

  • Title: test: [cp2.6]refactor connection method to prioritize uri/token and add query limit
  • Target: 2.6
  • Labels: sig/testing, size/L, area/test, dco-passed, kind/test, do-not-merge/need-merge-master-first, do-not-merge/need-milestone

[SUCCESS] PR #45901 merged to master

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@zhuwenxing cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@binbinlv binbinlv Awaiting requested review from binbinlv

@yanliang567 yanliang567 Awaiting requested review from yanliang567

Assignees

No one assigned

Labels

area/test dco-passed DCO check passed. kind/test sig/testing size/L Denotes a PR that changes 100-499 lines.

Projects

None yet

Milestone

2.6.7

Development

Successfully merging this pull request may close these issues.

2 participants

@zhuwenxing @sre-ci-robot