Skip to content

enhance: support proxy DML forward #45922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: 2.6
Choose a base branch
from
Open

enhance: support proxy DML forward #45922

wants to merge 1 commit into from

Conversation

@chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 27, 2025

issue: #45812
pr: #45921

  • 2.6 proxy will try to forward DWL to 2.5 proxy if streaming service is not ready

@chyezh
enhance: support proxy DML forward
399b35a 
- 2.6 proxy will try to forward DWL to 2.5 proxy if streaming service is not ready

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh added this to the 2.6.7 milestone Nov 27, 2025
@sre-ci-robot sre-ci-robot added area/internal-api size/XXL Denotes a PR that changes 1000+ lines. labels Nov 27, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 27, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign zhengbuqian after the PR has been reviewed.
You can assign the PR to them by writing /assign @zhengbuqian in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 27, 2025

[ci-v2-notice]
Notice: We are gradually rolling out the new ci-v2 system.

  • Legacy CI jobs remain unaffected, you can just ignore ci-v2 if you don't want to run it.
  • Additional "ci-v2/*" checkers will run for this PR to ensure the new ci-v2 system is working as expected.
  • For tests that exist in both v1 and v2, passing in either system is considered PASS.

To rerun ci-v2 checks, comment with:

  • /ci-rerun-code-check // for ci-v2/code-check
  • /ci-rerun-build // for ci-v2/build
  • /ci-rerun-ut-integration // for ci-v2/ut-integration
  • /ci-rerun-ut-go // for ci-v2/ut-go
  • /ci-rerun-ut-cpp // for ci-v2/ut-cpp
  • /ci-rerun-ut // for all ci-v2/ut-integration, ci-v2/ut-go, ci-v2/ut-cpp
  • /ci-rerun-e2e-arm // for ci-v2/e2e-arm [master branch only]
  • /ci-rerun-e2e-default // for ci-v2/e2e-default [master branch only]

If you have any questions or requests, please contact @zhikunyao.

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 27, 2025
@sre-ci-robot sre-ci-robot added the do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first label Nov 27, 2025
@sre-ci-robot
Copy link
Contributor

sre-ci-robot commented Nov 27, 2025

[INFO] PR Label Summary by Default
[FAILED] PR #45921 not merged

Use /refresh-label to update related check and label manually

@mergify
Copy link
Contributor

mergify bot commented Nov 27, 2025

@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@codecov
Copy link

codecov bot commented Nov 27, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 79.39914% with 48 lines in your changes missing coverage. Please review.
✅ Project coverage is 76.63%. Comparing base (cb08db0) to head (399b35a).
⚠️ Report is 314 commits behind head on 2.6.

Files with missing lines Patch % Lines
internal/distributed/streaming/forward.go 85.06% 15 Missing and 8 partials ⚠️
...ternal/streamingcoord/client/assignment/watcher.go 0.00% 9 Missing ⚠️
...amingutil/service/discoverer/session_discoverer.go 78.57% 6 Missing and 3 partials ⚠️
...treamingcoord/client/assignment/assignment_impl.go 0.00% 7 Missing ⚠️

❌ Your patch check has failed because the patch coverage (79.39%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.
❌ Your project check has failed because the head coverage (76.63%) is below the target coverage (77.00%). You can increase the head coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.6   #45922      +/-   ##
==========================================
- Coverage   76.99%   76.63%   -0.37%     
==========================================
  Files        1700     1857     +157     
  Lines      262533   287997   +25464     
==========================================
+ Hits       202142   220695   +18553     
- Misses      53550    59954    +6404     
- Partials     6841     7348     +507
Components Coverage Δ
Client 78.03% <65.76%> (-0.11%) ⬇️
Core 83.66% <79.71%> (+1.45%) ⬆️
Go 74.65% <52.20%> (-0.74%) ⬇️
Files with missing lines Coverage Δ
internal/distributed/proxy/service.go 77.63% <100.00%> (+0.06%) ⬆️
internal/distributed/streaming/wal.go 61.83% <100.00%> (+2.91%) ⬆️
internal/proxy/impl.go 72.97% <ø> (-0.93%) ⬇️
...nal/streamingcoord/client/assignment/discoverer.go 91.58% <100.00%> (+0.07%) ⬆️
internal/streamingcoord/client/client.go 94.11% <100.00%> (ø)
...al/streamingcoord/server/balancer/balancer_impl.go 74.13% <100.00%> (-0.22%) ⬇️
.../streamingcoord/server/balancer/channel/manager.go 83.33% <100.00%> (+12.16%) ⬆️
...er/service/discover/discover_grpc_server_helper.go 93.75% <100.00%> (+0.13%) ⬆️
...nal/streamingnode/client/manager/manager_client.go 93.75% <100.00%> (ø)
...nal/util/streamingutil/service/resolver/builder.go 91.66% <100.00%> (-1.36%) ⬇️
... and 5 more

... and 677 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 27, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 27, 2025

/ci-rerun-ut-go

@chyezh
Copy link
Contributor Author

chyezh commented Nov 27, 2025

/ci-rerun-ut-integration

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 27, 2025

/ci-rerun-ut-integration

@chyezh
Copy link
Contributor Author

chyezh commented Nov 27, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-integration

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-go

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/run-cpu-e2e

@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2025

@chyezh cpu-e2e job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-go

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-integration

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-integration

@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-go

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 28, 2025

/ci-rerun-ut-go

@mergify mergify bot added the ci-passed label Nov 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@czs007 czs007 Awaiting requested review from czs007

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees

No one assigned

Labels

area/internal-api ci-passed dco-passed DCO check passed. do-not-merge/need-merge-master-first any pr merge to release branch need to merge master first kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Milestone

2.6.7

Development

Successfully merging this pull request may close these issues.

2 participants

@chyezh @sre-ci-robot