Skip to content

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Apr 21, 2025

relate: #41213

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 21, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Apr 21, 2025
@aoiasd aoiasd changed the title feat: support more lauguage for build in stop words feat: support more lauguage for build in stop words and add remove punct, regex filter Apr 21, 2025
Copy link
Contributor

mergify bot commented Apr 21, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Apr 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.46%. Comparing base (5219d9a) to head (494c3c8).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41412      +/-   ##
==========================================
- Coverage   80.48%   80.46%   -0.03%     
==========================================
  Files        1488     1488              
  Lines      211245   211507     +262     
==========================================
+ Hits       170017   170185     +168     
- Misses      35061    35152      +91     
- Partials     6167     6170       +3     
Components Coverage Δ
Client 79.01% <ø> (ø)
Core 72.67% <ø> (+0.01%) ⬆️
Go 81.95% <ø> (-0.03%) ⬇️

see 59 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 21, 2025
@sunby
Copy link
Contributor

sunby commented Apr 22, 2025

/lgtm

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@congqixia
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit a16bd62 into milvus-io:master Apr 23, 2025
19 of 20 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Apr 23, 2025
…nct, regex filter (milvus-io#41412)

relate: milvus-io#41213

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants