Skip to content

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Apr 10, 2025

relate: #41213

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Apr 10, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Apr 10, 2025
Copy link

codecov bot commented Apr 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.59%. Comparing base (afb1b85) to head (57abef2).
Report is 46 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #41214       +/-   ##
===========================================
+ Coverage   72.32%   80.59%    +8.26%     
===========================================
  Files         310     1475     +1165     
  Lines       28670   209720   +181050     
===========================================
+ Hits        20736   169021   +148285     
- Misses       7934    34578    +26644     
- Partials        0     6121     +6121     
Components Coverage Δ
Client 79.59% <ø> (∅)
Core 72.32% <ø> (ø)
Go 82.01% <ø> (∅)

see 1165 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Apr 10, 2025
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sunby
Copy link
Contributor

sunby commented Apr 22, 2025

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 110c5aa into milvus-io:master Apr 22, 2025
20 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Apr 22, 2025
relate: milvus-io#41213

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved ci-passed dco-passed DCO check passed. kind/feature Issues related to feature request from users lgtm size/XXL Denotes a PR that changes 1000+ lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants