Skip to content

enhance: support use lindera tag filter #40416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 21, 2025
Merged

enhance: support use lindera tag filter #40416

merged 1 commit into from
Apr 21, 2025

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Mar 6, 2025

relate: #39659

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Mar 6, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Mar 6, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Mar 6, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Mar 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (1f1c836) to head (4c2b883).
Report is 28 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #40416      +/-   ##
==========================================
- Coverage   81.86%   80.60%   -1.26%     
==========================================
  Files        1166     1478     +312     
  Lines      181131   210142   +29011     
==========================================
+ Hits       148283   169393   +21110     
- Misses      26708    34619    +7911     
+ Partials     6140     6130      -10
Components Coverage Δ
Client 79.59% <ø> (ø)
Core 72.62% <ø> (∅)
Go 82.00% <100.00%> (+0.02%) ⬆️

see 339 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mergify mergify bot added the ci-passed label Mar 6, 2025
@zc277584121 zc277584121 mentioned this pull request Mar 10, 2025
Merged
@sunby
Copy link
Contributor

sunby commented Mar 17, 2025

/lgtm

@sre-ci-robot sre-ci-robot removed the lgtm label Apr 2, 2025
@mergify mergify bot removed the ci-passed label Apr 2, 2025
@aoiasd aoiasd force-pushed the C9 branch 2 times, most recently from ae62bae to e903ed2 Compare April 3, 2025 08:36
@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Apr 3, 2025

rerun go-sdk

@mergify Mergify
Copy link
Contributor

mergify bot commented Apr 3, 2025

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@aoiasd
support use lindera tag filter
4c2b883 
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@mergify mergify bot added the ci-passed label Apr 16, 2025
congqixia
congqixia approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

congqixia
congqixia approved these changes Apr 21, 2025
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f166843 into milvus-io:master Apr 21, 2025
20 checks passed
aoiasd added a commit to aoiasd/milvus that referenced this pull request Apr 22, 2025
@aoiasd
enhance: support use lindera tag filter (milvus-io#40416)
385f965 
relate: milvus-io#39659

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@aoiasd aoiasd mentioned this pull request Apr 22, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Apr 24, 2025
@aoiasd
feat: [2.5] Support run analyzer and more tokenizer. (#41444)
8b3353c 
relate: #39659
#39705
pr: #40416
#40458
#39723
#40813
#39854
#39660

---------

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@czs007 czs007 Awaiting requested review from czs007

Assignees

@sunby sunby

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aoiasd @sunby @sre-ci-robot @congqixia