Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Rectify run_clang_format grep command #39534

Merged

Conversation

congqixia
Copy link
Contributor

Previously the grep with regex does not work and failed to match lots of .cpp files

This PR:

  • use "-E" flag to use regex match
  • commit the fixed result of current cpp code

Previously the grep with regex does not work and failed to match lots of
.cpp files

This PR:
- use "-E" flag to use regex match
- commit the fixed result of current cpp code

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 23, 2025
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 23, 2025
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.98%. Comparing base (7476eb3) to head (12b1191).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/SearchBruteForce.cpp 0.00% 1 Missing ⚠️
internal/core/src/segcore/Utils.cpp 0.00% 1 Missing ⚠️
internal/core/src/storage/Util.cpp 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39534       +/-   ##
===========================================
+ Coverage   69.56%   80.98%   +11.41%     
===========================================
  Files         300     1407     +1107     
  Lines       26986   198816   +171830     
===========================================
+ Hits        18773   161007   +142234     
- Misses       8213    32110    +23897     
- Partials        0     5699     +5699     
Components Coverage Δ
Client 79.50% <ø> (∅)
Core 69.56% <25.00%> (ø)
Go 82.90% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/segcore/ConcurrentVector.h 95.97% <ø> (ø)
internal/core/src/query/SearchBruteForce.cpp 79.60% <0.00%> (ø)
internal/core/src/segcore/Utils.cpp 71.85% <0.00%> (ø)
internal/core/src/storage/Util.cpp 75.14% <50.00%> (ø)

... and 1107 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 23, 2025
@tedxu
Copy link
Contributor

tedxu commented Jan 23, 2025

/lgtm

@sre-ci-robot sre-ci-robot merged commit 844df76 into milvus-io:master Jan 23, 2025
19 of 20 checks passed
@congqixia congqixia deleted the enhance/fix_clangformat_script branch January 23, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants