Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: be able to handle tantivy indexes built from multiple segments #39127

Open
wants to merge 3 commits into
base: 2.4
Choose a base branch
from
Open

fix: be able to handle tantivy indexes built from multiple segments #39127

wants to merge 3 commits into from

Conversation

SpadeA-Tang
Copy link
Contributor

fix: #39126

@SpadeA-Tang
add logic to handle multiple segments; add tests
607941d 
Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: SpadeA-Tang
To complete the pull request process, please assign yanliang567 after the PR has been reviewed.
You can assign the PR to them by writing /assign @yanliang567 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jan 9, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 9, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@SpadeA-Tang Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jan 9, 2025
@SpadeA-Tang
revert wierd change
7bf556c 
Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 9, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@SpadeA-Tang
make fmt
d4cb85f 
Signed-off-by: SpadeA-Tang <tangchenjie1210@gmail.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 10, 2025

@SpadeA-Tang E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bigsheeper bigsheeper Awaiting requested review from bigsheeper

@xiaocai2333 xiaocai2333 Awaiting requested review from xiaocai2333

Assignees
No one assigned
Labels
dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SpadeA-Tang @sre-ci-robot