Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bulk insert failed when the nullable/default_value field is not exist(#39063) #39111

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

smellthemoon
Copy link
Contributor

pr: #39063
issue: #39036

…exist

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@smellthemoon smellthemoon changed the title fix: Bulk insert failed when the nullable/default_value field is not exist fix: Bulk insert failed when the nullable/default_value field is not exist(#39063) Jan 9, 2025
@sre-ci-robot sre-ci-robot requested a review from czs007 January 9, 2025 06:43
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 9, 2025
@sre-ci-robot sre-ci-robot requested a review from sunby January 9, 2025 06:43
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 9, 2025
@bigsheeper
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 70.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (ff3a128) to head (e98524b).
Report is 5 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/util/importutilv2/json/row_parser.go 70.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #39111      +/-   ##
==========================================
+ Coverage   81.05%   81.07%   +0.02%     
==========================================
  Files        1384     1384              
  Lines      195594   195604      +10     
==========================================
+ Hits       158535   158584      +49     
+ Misses      31483    31458      -25     
+ Partials     5576     5562      -14     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.44% <ø> (ø)
Go 83.06% <70.00%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/util/importutilv2/json/row_parser.go 57.82% <70.00%> (+0.20%) ⬆️

... and 27 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 9, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f896b0e into milvus-io:2.5 Jan 9, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants