Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix in filter search result is empty if pk type is varchar #39106

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Jan 9, 2025

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 9, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jan 9, 2025
Copy link
Contributor

mergify bot commented Jan 9, 2025

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link

codecov bot commented Jan 9, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.14%. Comparing base (182cac0) to head (f87a480).
Report is 36 commits behind head on master.

Files with missing lines Patch % Lines
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #39106      +/-   ##
==========================================
- Coverage   81.14%   81.14%   -0.01%     
==========================================
  Files        1388     1390       +2     
  Lines      196538   196756     +218     
==========================================
+ Hits       159485   159651     +166     
- Misses      31463    31512      +49     
- Partials     5590     5593       +3     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core 69.53% <0.00%> (-0.01%) ⬇️
Go 83.09% <ø> (-0.01%) ⬇️
Files with missing lines Coverage Δ
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 22.81% <0.00%> (-0.03%) ⬇️

... and 62 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 9, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a00ba86 into milvus-io:master Jan 13, 2025
18 of 20 checks passed
gifi-siby pushed a commit to gifi-siby/milvus that referenced this pull request Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants