Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Upgrade go version in docker images #39016

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

XuanYang-cn
Copy link
Contributor

upgrade go version to 1.22.10

See also: #39011

upgrade go version to 1.22.10

See also: milvus-io#39011

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: XuanYang-cn
To complete the pull request process, please assign jiaoew1991 after the PR has been reviewed.
You can assign the PR to them by writing /assign @jiaoew1991 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jan 6, 2025
@mergify mergify bot added the dco-passed DCO check passed. label Jan 6, 2025
Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (ee9a279) to head (acb7d06).
Report is 4 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #39016       +/-   ##
===========================================
+ Coverage   69.52%   81.16%   +11.63%     
===========================================
  Files         296     1388     +1092     
  Lines       26553   196536   +169983     
===========================================
+ Hits        18462   159522   +141060     
- Misses       8091    31420    +23329     
- Partials        0     5594     +5594     
Components Coverage Δ
Client 79.53% <ø> (∅)
Core 69.53% <ø> (+<0.01%) ⬆️
Go 83.12% <ø> (∅)

see 1102 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Jan 6, 2025
@mergify mergify bot removed the ci-passed label Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

/run-cpu-e2e

@XuanYang-cn XuanYang-cn changed the title Upgrade go version in docker images enhance: Upgrade go version in docker images Jan 7, 2025
@mergify mergify bot added kind/enhancement Issues or changes related to enhancement and removed do-not-merge/invalid-pr-format labels Jan 7, 2025
Copy link
Contributor

mergify bot commented Jan 7, 2025

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label Jan 7, 2025
sre-ci-robot pushed a commit that referenced this pull request Jan 9, 2025
Cherry pick from master
pr: #39016
#39107

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants