Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Increase the buffer capacity of notifyIndexChan to support concurrency #38957

Merged
merged 1 commit into from
Jan 5, 2025
Merged

enhance: Increase the buffer capacity of notifyIndexChan to support concurrency #38957

merged 1 commit into from
Jan 5, 2025

Conversation

xiaocai2333
Copy link
Contributor

No description provided.

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jan 2, 2025
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 2, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@codecov Codecov
Copy link

codecov bot commented Jan 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.16%. Comparing base (d9ebb70) to head (7d1e5d2).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38957      +/-   ##
==========================================
+ Coverage   81.12%   81.16%   +0.04%     
==========================================
  Files        1387     1387              
  Lines      196269   196269              
==========================================
+ Hits       159215   159297      +82     
+ Misses      31452    31392      -60     
+ Partials     5602     5580      -22
Components Coverage Δ
Client 79.12% <ø> (ø)
Core 69.56% <ø> (+0.01%) ⬆️
Go 83.12% <100.00%> (+0.04%) ⬆️
Files with missing lines Coverage Δ
internal/datacoord/server.go 73.22% <100.00%> (ø)

... and 22 files with indirect coverage changes

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@xiaocai2333 go-sdk check failed, comment rerun go-sdk can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

rerun go-sdk

@xiaocai2333
Increase the buffer capacity of notifyIndexChan to support concurrency
7d1e5d2 
Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 3, 2025

@xiaocai2333 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@xiaocai2333
Copy link
Contributor Author

/run-cpu-e2e

@xiaocai2333
Copy link
Contributor Author

rerun ut

@mergify mergify bot added the ci-passed label Jan 4, 2025
@czs007
Copy link
Collaborator

czs007 commented Jan 5, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, xiaocai2333

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9672eee into milvus-io:master Jan 5, 2025
20 checks passed
@xiaocai2333 xiaocai2333 mentioned this pull request Jan 6, 2025
Merged
sre-ci-robot pushed a commit that referenced this pull request Jan 6, 2025
@xiaocai2333
fix: [2.5]Remove valid expressions from invalid expressions (#38999)
e6dd3e5 
issue: #39014 

master pr: #38957 
master pr: #39012

---------

Signed-off-by: Cai Zhang <cai.zhang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia Awaiting requested review from congqixia

@cydrain cydrain Awaiting requested review from cydrain

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xiaocai2333 @czs007 @sre-ci-robot