-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: make serialization be part of sync task to support file format change #38946
enhance: make serialization be part of sync task to support file format change #38946
Conversation
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #38946 +/- ##
==========================================
+ Coverage 80.98% 81.01% +0.02%
==========================================
Files 1407 1408 +1
Lines 198693 198627 -66
==========================================
- Hits 160921 160915 -6
+ Misses 32102 32052 -50
+ Partials 5670 5660 -10
|
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
@tedxu cpp-unit-test check failed, comment |
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
@tedxu cpp-unit-test check failed, comment |
983633c
to
948a29f
Compare
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
1 similar comment
@tedxu go-sdk check failed, comment |
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
@tedxu E2e jenkins job failed, comment |
@tedxu go-sdk check failed, comment |
rerun go-sdk |
@tedxu E2e jenkins job failed, comment |
/run-cpu-e2e |
…at change Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
d078858
to
d8bd795
Compare
@tedxu go-sdk check failed, comment |
@tedxu E2e jenkins job failed, comment |
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu go-sdk check failed, comment |
@tedxu E2e jenkins job failed, comment |
rerun go-sdk |
@tedxu go-sdk check failed, comment |
/run-cpu-e2e |
rerun go-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See #38945