Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: make serialization be part of sync task to support file format change #38946

Merged
merged 9 commits into from
Jan 23, 2025

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Jan 2, 2025

See #38945

@sre-ci-robot sre-ci-robot added approved size/XXL Denotes a PR that changes 1000+ lines. labels Jan 2, 2025
@sre-ci-robot sre-ci-robot requested review from czs007 and sunby January 2, 2025 09:03
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jan 2, 2025
Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 2, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Jan 2, 2025

Codecov Report

Attention: Patch coverage is 64.80836% with 101 lines in your changes missing coverage. Please review.

Project coverage is 81.01%. Comparing base (7261128) to head (441f943).
Report is 17 commits behind head on master.

Files with missing lines Patch % Lines
internal/flushcommon/syncmgr/pack_writer.go 58.41% 74 Missing and 15 partials ⚠️
internal/flushcommon/syncmgr/storage_serializer.go 57.14% 5 Missing and 1 partial ⚠️
internal/flushcommon/syncmgr/task.go 78.94% 2 Missing and 2 partials ⚠️
internal/flushcommon/syncmgr/meta_writer.go 75.00% 0 Missing and 1 partial ⚠️
internal/flushcommon/syncmgr/options.go 95.65% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38946      +/-   ##
==========================================
+ Coverage   80.98%   81.01%   +0.02%     
==========================================
  Files        1407     1408       +1     
  Lines      198693   198627      -66     
==========================================
- Hits       160921   160915       -6     
+ Misses      32102    32052      -50     
+ Partials     5670     5660      -10     
Components Coverage Δ
Client 79.50% <ø> (ø)
Core 69.56% <ø> (ø)
Go 82.94% <64.80%> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/datanode/importv2/util.go 65.21% <100.00%> (-0.07%) ⬇️
internal/flushcommon/writebuffer/write_buffer.go 70.84% <100.00%> (-2.54%) ⬇️
internal/storage/data_codec.go 77.72% <100.00%> (+0.02%) ⬆️
pkg/metrics/datanode_metrics.go 100.00% <ø> (ø)
internal/flushcommon/syncmgr/meta_writer.go 79.16% <75.00%> (ø)
internal/flushcommon/syncmgr/options.go 92.85% <95.65%> (-7.15%) ⬇️
internal/flushcommon/syncmgr/task.go 92.92% <78.94%> (+10.55%) ⬆️
internal/flushcommon/syncmgr/storage_serializer.go 48.22% <57.14%> (-13.45%) ⬇️
internal/flushcommon/syncmgr/pack_writer.go 58.41% <58.41%> (ø)

... and 44 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@tedxu tedxu force-pushed the enhance/serialize_sync_task branch from 983633c to 948a29f Compare January 6, 2025 07:16
Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 6, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

1 similar comment
Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 8, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 8, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 8, 2025

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Jan 8, 2025
tedxu added 2 commits January 21, 2025 12:27
…at change

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu added 6 commits January 21, 2025 12:28
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu force-pushed the enhance/serialize_sync_task branch from d078858 to d8bd795 Compare January 21, 2025 04:28
@mergify mergify bot removed the ci-passed label Jan 21, 2025
Copy link
Contributor

mergify bot commented Jan 21, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 21, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Copy link
Contributor

mergify bot commented Jan 22, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 22, 2025

@tedxu E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 22, 2025

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 22, 2025

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

@tedxu
Copy link
Contributor Author

tedxu commented Jan 23, 2025

/run-cpu-e2e

@tedxu
Copy link
Contributor Author

tedxu commented Jan 23, 2025

rerun go-sdk

@mergify mergify bot added the ci-passed label Jan 23, 2025
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 56659ba into milvus-io:master Jan 23, 2025
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants