enhance: [2.5] Skip creating partition rate limiters when not enable #38911
Conversation
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
mergify
bot
added
dco-passed
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 2.5 #38911 +/- ##
===========================================
- Coverage 81.02% 69.58% -11.45%
===========================================
Files 1400 297 -1103
Lines 197477 26557 -170920
===========================================
- Hits 160013 18480 -141533
+ Misses 31840 8077 -23763
+ Partials 5624 0 -5624
|
…kip-create-ratelimiter-2.5
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
|
@bigsheeper go-sdk check failed, comment |
…kip-create-ratelimiter-2.5
|
@bigsheeper go-sdk check failed, comment |
…kip-create-ratelimiter-2.5
| for rt := range getRateTypes(internalpb.RateScope_Partition, allOps) { | ||
| r := quota.GetQuotaValue(internalpb.RateScope_Partition, rt, Params) | ||
| if Limit(r) != Inf { | ||
| enablePartitionRateLimit = true |
There was a problem hiding this comment.
could break early.
not critical.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bigsheeper, czs007 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@bigsheeper go-sdk check failed, comment |
issue: #37630
pr: #38816