Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [2.5] add param for tuning max VARCHAR length and restore limit to 65535 #38883

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

PwzXxm
Copy link
Contributor

@PwzXxm PwzXxm commented Dec 31, 2024

issue: #38882
pr: #38884

Signed-off-by: Patrick Weizhi Xu weizhi.xu@zilliz.com
(cherry picked from commit a64a737)

@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing labels Dec 31, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@PwzXxm Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement and removed do-not-merge/missing-related-pr labels Dec 31, 2024
Copy link
Contributor

mergify bot commented Dec 31, 2024

@PwzXxm go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 31, 2024

Codecov Report

Attention: Patch coverage is 69.23077% with 4 lines in your changes missing coverage. Please review.

Project coverage is 81.07%. Comparing base (84f8737) to head (a8ee962).
Report is 4 commits behind head on 2.5.

Files with missing lines Patch % Lines
internal/proxy/task.go 0.00% 3 Missing ⚠️
internal/proxy/util.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38883      +/-   ##
==========================================
- Coverage   81.07%   81.07%   -0.01%     
==========================================
  Files        1383     1383              
  Lines      195500   195510      +10     
==========================================
+ Hits       158510   158512       +2     
+ Misses      31436    31434       -2     
- Partials     5554     5564      +10     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.46% <ø> (+0.01%) ⬆️
Go 83.05% <69.23%> (-0.01%) ⬇️
Files with missing lines Coverage Δ
pkg/util/paramtable/component_param.go 98.39% <100.00%> (+<0.01%) ⬆️
internal/proxy/util.go 89.46% <50.00%> (+<0.01%) ⬆️
internal/proxy/task.go 80.64% <0.00%> (-0.05%) ⬇️

... and 36 files with indirect coverage changes

@PwzXxm
Copy link
Contributor Author

PwzXxm commented Dec 31, 2024

/hold

Signed-off-by: Patrick Weizhi Xu <weizhi.xu@zilliz.com>
(cherry picked from commit 72fecd4)
(cherry picked from commit 8166759)
@PwzXxm PwzXxm force-pushed the add_varchar_param_2.5 branch from 8e740e0 to a8ee962 Compare December 31, 2024 08:36
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/S Denotes a PR that changes 10-29 lines. labels Dec 31, 2024
@PwzXxm PwzXxm changed the title enhance: [2.5] add MaxVarCharLength param, defaults to 1M in 2.5.x enhance: [2.5] add param for tuning max VARCHAR length Dec 31, 2024
@PwzXxm PwzXxm changed the title enhance: [2.5] add param for tuning max VARCHAR length enhance: [2.5] add param for tuning max VARCHAR length and restore limit to 65535 Dec 31, 2024
@PwzXxm
Copy link
Contributor Author

PwzXxm commented Dec 31, 2024

/unhold

@liliu-z
Copy link
Member

liliu-z commented Jan 2, 2025

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, PwzXxm

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 1d55ad6 into milvus-io:2.5 Jan 2, 2025
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants