Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [skip e2e]update webui collection and query pages #38701

Merged
merged 1 commit into from
Dec 24, 2024

Conversation

mimoning
Copy link
Contributor

pr: #38700
issue: #36621

  • enhance collection detail page list columns
  • enhance query page segments state detail logic

Signed-off-by: mimo.oyn <ning.ouyang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 24, 2024
@mimoning mimoning changed the title fix: update webui collection and query pages fix: [skip e2e]update webui collection and query pages Dec 24, 2024
Copy link
Contributor

mergify bot commented Dec 24, 2024

@mimoning Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Dec 24, 2024
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.02%. Comparing base (c51b458) to head (3a233bb).
Report is 1 commits behind head on 2.5.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.5   #38701      +/-   ##
==========================================
- Coverage   81.04%   81.02%   -0.02%     
==========================================
  Files        1381     1381              
  Lines      195099   195099              
==========================================
- Hits       158110   158084      -26     
- Misses      31422    31438      +16     
- Partials     5567     5577      +10     
Components Coverage Δ
Client 78.26% <ø> (ø)
Core 69.33% <ø> (ø)
Go 83.00% <ø> (-0.02%) ⬇️

see 30 files with indirect coverage changes

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: mimoning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815
Copy link
Contributor

/lgtm

@sre-ci-robot sre-ci-robot merged commit 18cc83b into milvus-io:2.5 Dec 24, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/bug Issues or changes related a bug lgtm size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants