Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: growing-groupby-crush(#38533) #38538

Merged

Conversation

MrPresent-Han
Copy link
Contributor

related: #38533

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Dec 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 17, 2024
@czs007 czs007 added this to the 2.5.0 milestone Dec 17, 2024
@cqy123456
Copy link
Contributor

/lgtm

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrPresent-Han, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@xiaofan-luan xiaofan-luan merged commit decdfda into milvus-io:master Dec 17, 2024
10 of 14 checks passed
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.

Project coverage is 80.95%. Comparing base (e19a4f7) to head (8d10e56).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
.../src/exec/operator/groupby/SearchGroupByOperator.h 33.33% 2 Missing ⚠️
internal/core/src/mmap/ChunkVector.h 0.00% 2 Missing ⚠️
internal/core/src/segcore/ConcurrentVector.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38538      +/-   ##
==========================================
- Coverage   82.80%   80.95%   -1.86%     
==========================================
  Files        1086     1378     +292     
  Lines      167965   194187   +26222     
==========================================
+ Hits       139088   157198   +18110     
- Misses      23336    31433    +8097     
- Partials     5541     5556      +15     
Components Coverage Δ
Client 74.52% <ø> (ø)
Core 69.33% <16.66%> (∅)
Go 83.00% <100.00%> (-0.05%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/segcore/ConcurrentVector.h 95.83% <0.00%> (ø)
.../src/exec/operator/groupby/SearchGroupByOperator.h 85.71% <33.33%> (ø)
internal/core/src/mmap/ChunkVector.h 83.87% <0.00%> (ø)

... and 329 files with indirect coverage changes

sre-ci-robot pushed a commit that referenced this pull request Dec 18, 2024
related: #38533
pr: #38538

Signed-off-by: MrPresent-Han <chun.han@gmail.com>
Co-authored-by: MrPresent-Han <chun.han@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants