Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: allow hyphen in partition name #38494

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 16, 2024

No description provided.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added area/test sig/testing size/S Denotes a PR that changes 10-29 lines. labels Dec 16, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.99%. Comparing base (1e27438) to head (3a018b1).
Report is 41 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38494      +/-   ##
==========================================
+ Coverage   80.88%   80.99%   +0.10%     
==========================================
  Files        1373     1379       +6     
  Lines      193020   194358    +1338     
==========================================
+ Hits       156131   157411    +1280     
- Misses      31374    31402      +28     
- Partials     5515     5545      +30     
Components Coverage Δ
Client 75.27% <ø> (+0.69%) ⬆️
Core 69.32% <ø> (+0.39%) ⬆️
Go 83.03% <100.00%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/util.go 89.63% <100.00%> (-0.26%) ⬇️

... and 219 files with indirect coverage changes

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@mergify mergify bot added the ci-passed label Dec 18, 2024
@liliu-z
Copy link
Member

liliu-z commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 894c203 into milvus-io:master Dec 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants