Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: allow hyphen in partition name #38474

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 16, 2024

No description provided.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added size/S Denotes a PR that changes 10-29 lines. area/test sig/testing labels Dec 16, 2024
@mergify mergify bot added the dco-passed DCO check passed. label Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement ci-passed labels Dec 16, 2024
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.42%. Comparing base (1da4ac4) to head (a8b62ee).
Report is 15 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #38474      +/-   ##
==========================================
+ Coverage   79.50%   80.42%   +0.91%     
==========================================
  Files        1077     1077              
  Lines      169330   169357      +27     
==========================================
+ Hits       134633   136205    +1572     
+ Misses      30234    28692    -1542     
+ Partials     4463     4460       -3     
Files with missing lines Coverage Δ
internal/proxy/util.go 90.66% <100.00%> (ø)

... and 94 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.18 milestone Dec 17, 2024
@liliu-z
Copy link
Member

liliu-z commented Dec 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liliu-z, sunby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b469999 into milvus-io:2.4 Dec 18, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants