Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support query aggregtion #38452

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MrPresent-Han
Copy link
Contributor

related: #36380

@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Dec 13, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrPresent-Han
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/feature Issues related to feature request from users labels Dec 13, 2024
@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from da04176 to 00539b3 Compare December 13, 2024 10:18
Copy link
Contributor

mergify bot commented Dec 13, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 13, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 13, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 00539b3 to 71228b0 Compare December 16, 2024 09:54
Copy link
Contributor

mergify bot commented Dec 16, 2024

@MrPresent-Han Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.

@mergify mergify bot added needs-dco DCO is missing in this pull request. and removed dco-passed DCO check passed. labels Dec 16, 2024
Copy link
Contributor

mergify bot commented Dec 16, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 16, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 16, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 71228b0 to 4c483c8 Compare December 19, 2024 10:12
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. labels Dec 19, 2024
Copy link
Contributor

mergify bot commented Dec 19, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 19, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 19, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 4c483c8 to 9ae8a1b Compare December 20, 2024 02:23
Copy link
Contributor

mergify bot commented Dec 20, 2024

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 20, 2024

@MrPresent-Han cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 9ae8a1b to 942ce20 Compare December 20, 2024 10:39
Copy link
Contributor

mergify bot commented Jan 7, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 7, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 63.62416% with 271 lines in your changes missing coverage. Please review.

Project coverage is 82.84%. Comparing base (e5eb115) to head (00e8f94).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
internal/agg/aggregate.go 63.16% 172 Missing and 21 partials ⚠️
internal/proxy/task_query.go 64.78% 21 Missing and 4 partials ⚠️
internal/proxy/util.go 42.42% 17 Missing and 2 partials ⚠️
internal/util/typeutil/hash.go 50.00% 15 Missing ⚠️
internal/querynodev2/handlers.go 56.25% 5 Missing and 2 partials ⚠️
internal/querynodev2/segments/agg_reducer.go 77.77% 4 Missing and 2 partials ⚠️
internal/proxy/agg_reducer.go 84.21% 2 Missing and 1 partial ⚠️
internal/querynodev2/services.go 40.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38452      +/-   ##
==========================================
+ Coverage   81.11%   82.84%   +1.72%     
==========================================
  Files        1395     1100     -295     
  Lines      197298   171236   -26062     
==========================================
- Hits       160037   141854   -18183     
+ Misses      31623    23731    -7892     
- Partials     5638     5651      +13     
Components Coverage Δ
Client 79.53% <ø> (ø)
Core ∅ <ø> (∅)
Go 82.97% <65.47%> (-0.07%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/reducer.go 100.00% <100.00%> (ø)
internal/proxy/task.go 80.64% <ø> (ø)
internal/proxy/task_search.go 76.34% <100.00%> (-0.24%) ⬇️
internal/querynodev2/segments/reducer.go 90.90% <100.00%> (ø)
internal/querynodev2/segments/result.go 71.58% <ø> (+0.06%) ⬆️
internal/querynodev2/segments/segment.go 65.16% <ø> (ø)
internal/querynodev2/server.go 77.57% <100.00%> (+0.11%) ⬆️
internal/querynodev2/tasks/search_task.go 84.47% <100.00%> (+0.03%) ⬆️
internal/util/initcore/init_core.go 87.03% <100.00%> (+0.16%) ⬆️
internal/util/segmentutil/utils.go 100.00% <100.00%> (ø)
... and 8 more

... and 324 files with indirect coverage changes

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 4c54272 to bc75897 Compare January 8, 2025 06:10
Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from bc75897 to 7407153 Compare January 8, 2025 09:50
Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 7407153 to 9180c72 Compare January 8, 2025 14:00
Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 8, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from da83f26 to 5326b65 Compare January 9, 2025 09:59
Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han
Copy link
Contributor Author

MrPresent-Han commented Jan 9, 2025

/run-cpu-e2e

@MrPresent-Han
Copy link
Contributor Author

rerun go-sdk

Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 9, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from 5326b65 to e6a2d7d Compare January 10, 2025 03:00
Signed-off-by: MrPresent-Han <chun.han@gmail.com>
@MrPresent-Han MrPresent-Han force-pushed the support-query-agg-review branch from e6a2d7d to 00e8f94 Compare January 10, 2025 09:29
Copy link
Contributor

mergify bot commented Jan 10, 2025

@MrPresent-Han go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Jan 10, 2025

@MrPresent-Han E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation area/internal-api area/test dco-passed DCO check passed. kind/feature Issues related to feature request from users sig/testing size/XXL Denotes a PR that changes 1000+ lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants