Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: eliminate compile warnings #38420

Merged

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Dec 12, 2024

See: #38435

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/compilation labels Dec 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 12, 2024
Copy link
Contributor

mergify bot commented Dec 12, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 56.25000% with 14 lines in your changes missing coverage. Please review.

Project coverage is 80.89%. Comparing base (0d7a89a) to head (434e42b).
Report is 27 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/mmap/ChunkedColumn.h 12.50% 7 Missing ⚠️
internal/core/src/common/ChunkWriter.h 50.00% 3 Missing ⚠️
internal/core/src/common/ChunkWriter.cpp 66.66% 2 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38420      +/-   ##
==========================================
- Coverage   80.90%   80.89%   -0.02%     
==========================================
  Files        1376     1373       -3     
  Lines      192740   192952     +212     
==========================================
+ Hits       155938   156086     +148     
- Misses      31289    31345      +56     
- Partials     5513     5521       +8     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.91% <56.25%> (-0.01%) ⬇️
Go 83.00% <ø> (-0.02%) ⬇️
Files with missing lines Coverage Δ
internal/core/src/common/Chunk.h 60.71% <100.00%> (ø)
internal/core/src/common/FieldData.h 100.00% <100.00%> (ø)
internal/core/src/exec/expression/Expr.cpp 94.16% <100.00%> (ø)
internal/core/src/exec/expression/Expr.h 69.04% <ø> (ø)
internal/core/src/exec/expression/UnaryExpr.cpp 84.51% <100.00%> (ø)
internal/core/src/exec/expression/UnaryExpr.h 68.51% <ø> (ø)
.../src/exec/operator/groupby/SearchGroupByOperator.h 84.00% <100.00%> (-1.72%) ⬇️
internal/core/src/mmap/ChunkData.h 97.29% <ø> (-0.14%) ⬇️
internal/core/src/mmap/Column.h 90.88% <100.00%> (+0.02%) ⬆️
internal/core/src/common/ChunkWriter.cpp 54.45% <66.66%> (ø)
... and 3 more

... and 64 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Dec 13, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
@tedxu tedxu force-pushed the enhance/eliminate_compile_warnings branch from af30942 to 434e42b Compare December 13, 2024 03:25
@sunby
Copy link
Contributor

sunby commented Dec 13, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 4919ccf into milvus-io:master Dec 16, 2024
17 of 20 checks passed
@tedxu tedxu deleted the enhance/eliminate_compile_warnings branch December 17, 2024 04:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/compilation ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants