Skip to content

Conversation

JsDove
Copy link
Contributor

@JsDove JsDove commented Dec 11, 2024

alterdatabase support delete property
issue: #38379

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. area/dependency Pull requests that update a dependency file labels Dec 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 11, 2024
Copy link

codecov bot commented Dec 11, 2024

Codecov Report

Attention: Patch coverage is 52.63158% with 18 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (74c6e0e) to head (c4ba1cb).
Report is 14 commits behind head on master.

Files with missing lines Patch % Lines
internal/rootcoord/quota_center.go 40.00% 12 Missing ⚠️
internal/rootcoord/alter_database_task.go 64.70% 5 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #38380       +/-   ##
===========================================
+ Coverage   68.92%   80.91%   +11.99%     
===========================================
  Files         292     1376     +1084     
  Lines       26153   193081   +166928     
===========================================
+ Hits        18025   156234   +138209     
- Misses       8128    31327    +23199     
- Partials        0     5520     +5520     
Components Coverage Δ
Client 74.58% <ø> (∅)
Core 68.91% <ø> (-0.01%) ⬇️
Go 83.03% <52.63%> (∅)
Files with missing lines Coverage Δ
internal/proxy/task_database.go 97.96% <100.00%> (ø)
internal/rootcoord/alter_collection_task.go 46.70% <ø> (ø)
internal/rootcoord/alter_database_task.go 80.85% <64.70%> (ø)
internal/rootcoord/quota_center.go 82.29% <40.00%> (ø)

... and 1081 files with indirect coverage changes

Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
Copy link
Contributor

mergify bot commented Dec 11, 2024

@JsDove cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 11, 2024

@JsDove E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@JsDove
Copy link
Contributor Author

JsDove commented Dec 12, 2024

/run-cpu-e2e

@JsDove
Copy link
Contributor Author

JsDove commented Dec 12, 2024

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Dec 12, 2024
Signed-off-by: Xianhui.Lin <xianhui.lin@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Dec 12, 2024
@mergify mergify bot removed the ci-passed label Dec 12, 2024
@czs007
Copy link
Collaborator

czs007 commented Dec 12, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, JsDove

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Dec 12, 2024
@sre-ci-robot sre-ci-robot merged commit d0a8110 into milvus-io:master Dec 12, 2024
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants