Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add collection id to search request count metrics (#38069) #38144

Merged
merged 2 commits into from
Dec 3, 2024

Conversation

weiliu1031
Copy link
Contributor

@weiliu1031 weiliu1031 commented Dec 2, 2024

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Dec 2, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 95.83333% with 3 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (580caeb) to head (99b6de1).
Report is 4 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/querynodev2/handlers.go 75.00% 2 Missing ⚠️
internal/querynodev2/services.go 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##              2.4   #38144       +/-   ##
===========================================
+ Coverage   11.59%   80.56%   +68.97%     
===========================================
  Files         268     1073      +805     
  Lines       26465   167708   +141243     
===========================================
+ Hits         3068   135111   +132043     
- Misses      23397    28154     +4757     
- Partials        0     4443     +4443     
Files with missing lines Coverage Δ
pkg/metrics/querynode_metrics.go 100.00% <100.00%> (ø)
internal/querynodev2/services.go 86.96% <88.88%> (ø)
internal/querynodev2/handlers.go 77.58% <75.00%> (ø)

... and 1001 files with indirect coverage changes

@weiliu1031
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Dec 2, 2024

@weiliu1031 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@mergify mergify bot added the ci-passed label Dec 3, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, weiliu1031

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b29237e into milvus-io:2.4 Dec 3, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants