Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix IsMmapSupported for scalar index #38135

Merged
merged 2 commits into from
Dec 17, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented Dec 2, 2024

@sunby sunby changed the title fix: Fix IsMmapSupported interface fix: Fix IsMmapSupported for scalar index Dec 2, 2024
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Dec 2, 2024
@sre-ci-robot sre-ci-robot requested a review from xige-16 December 2, 2024 06:59
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Dec 2, 2024
Copy link
Contributor

mergify bot commented Dec 2, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@sunby cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Dec 2, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Dec 2, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 4 lines in your changes missing coverage. Please review.

Project coverage is 80.91%. Comparing base (7a5aea1) to head (66ab76a).
Report is 71 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/index/ScalarIndex.h 0.00% 4 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #38135      +/-   ##
==========================================
- Coverage   81.08%   80.91%   -0.17%     
==========================================
  Files        1372     1373       +1     
  Lines      191671   192086     +415     
==========================================
+ Hits       155412   155425      +13     
- Misses      30762    31142     +380     
- Partials     5497     5519      +22     
Components Coverage Δ
Client 74.58% <ø> (ø)
Core 68.83% <0.00%> (-0.01%) ⬇️
Go 82.99% <100.00%> (-0.21%) ⬇️
Files with missing lines Coverage Δ
internal/util/indexparamcheck/index_type.go 67.44% <100.00%> (+0.77%) ⬆️
internal/core/src/index/ScalarIndex.h 23.25% <0.00%> (-1.75%) ⬇️

... and 58 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented Dec 3, 2024

rerun go-sdk

1 similar comment
@sunby
Copy link
Contributor Author

sunby commented Dec 9, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 9, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented Dec 9, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Dec 9, 2024

@sunby go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sunby sunby force-pushed the fix_mmap_supported_index branch from 229da58 to 66ab76a Compare December 11, 2024 03:26
@mergify mergify bot added the ci-passed label Dec 11, 2024
@czs007 czs007 added this to the 2.5.0 milestone Dec 17, 2024
@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit f0096ec into milvus-io:master Dec 17, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants