Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [24]Replace outer lock with concurrent map (#37817) #37897

Merged
merged 3 commits into from
Nov 29, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37493
pr: #37817

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 21, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 21, 2024
Copy link
Contributor

mergify bot commented Nov 21, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

See also: milvus-io#37493
pr: milvus-io#37817

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 83.69%. Comparing base (6088a1f) to head (0043fb5).
Report is 13 commits behind head on 2.4.

Files with missing lines Patch % Lines
internal/datanode/writebuffer/manager.go 91.66% 0 Missing and 2 partials ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #37897      +/-   ##
==========================================
+ Coverage   80.63%   83.69%   +3.06%     
==========================================
  Files        1070      802     -268     
  Lines      167426   140929   -26497     
==========================================
- Hits       135000   117953   -17047     
+ Misses      28005    18546    -9459     
- Partials     4421     4430       +9     
Files with missing lines Coverage Δ
internal/datanode/writebuffer/write_buffer.go 76.64% <100.00%> (-0.21%) ⬇️
internal/datanode/writebuffer/manager.go 93.15% <91.66%> (+0.57%) ⬆️

... and 300 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.18 milestone Nov 26, 2024
@mergify mergify bot added the ci-passed label Nov 27, 2024
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 8ae7cdd into milvus-io:2.4 Nov 29, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the cp24/fix-lock branch November 29, 2024 07:41
bigsheeper pushed a commit to bigsheeper/milvus that referenced this pull request Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants