Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [GoSDK] Use generic column base and add unit tests #37768

Merged

Conversation

congqixia
Copy link
Contributor

Related to #31293

Previous column is written using go before 1.18, which does not support generic type. After migrating client pkg to main repo, generic base could be used to reduce lots of duplicated code.

Related to milvus-io#31293

Previous column is written using go before 1.18, which does not support
generic type. After migrating client pkg to main repo, generic base
could be used to reduce lots of duplicated code.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot sre-ci-robot added size/XXL Denotes a PR that changes 1000+ lines. approved area/test sig/testing labels Nov 18, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia go-sdk check failed, comment rerun go-sdk can trigger the job again.

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@congqixia
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 77.81513% with 132 lines in your changes missing coverage. Please review.

Project coverage is 81.03%. Comparing base (e9391ac) to head (78fc0c2).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
client/column/scalar.go 53.33% 56 Missing ⚠️
client/column/array.go 57.33% 32 Missing ⚠️
client/column/generic_base.go 78.66% 14 Missing and 2 partials ⚠️
client/column/vector.go 77.77% 16 Missing ⚠️
client/column/conversion.go 96.38% 5 Missing and 3 partials ⚠️
client/column/json.go 78.57% 3 Missing ⚠️
client/column/dynamic.go 80.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37768      +/-   ##
==========================================
+ Coverage   80.68%   81.03%   +0.34%     
==========================================
  Files        1357     1356       -1     
  Lines      190831   189836     -995     
==========================================
- Hits       153974   153826     -148     
+ Misses      31436    30565     -871     
- Partials     5421     5445      +24     
Components Coverage Δ
Client 72.16% <77.81%> (+10.90%) ⬆️
Core 68.85% <ø> (ø)
Go 83.21% <ø> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
client/column/columns.go 75.07% <100.00%> (+27.83%) ⬆️
client/column/sparse.go 100.00% <100.00%> (+27.63%) ⬆️
client/column/dynamic.go 85.50% <80.00%> (ø)
client/column/json.go 83.72% <78.57%> (+14.75%) ⬆️
client/column/conversion.go 96.38% <96.38%> (+96.38%) ⬆️
client/column/generic_base.go 78.66% <78.66%> (ø)
client/column/vector.go 77.77% <77.77%> (ø)
client/column/array.go 65.97% <57.33%> (+65.97%) ⬆️
client/column/scalar.go 53.33% <53.33%> (ø)

... and 36 files with indirect coverage changes

---- 🚨 Try these New Features:

Copy link
Contributor

mergify bot commented Nov 18, 2024

@congqixia E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 18, 2024
Copy link
Contributor

@ThreadDao ThreadDao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot sre-ci-robot merged commit 175f49e into milvus-io:master Nov 19, 2024
19 of 20 checks passed
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 19, 2024
Related to milvus-io#37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia congqixia deleted the enhance/gosdk/generic_columns branch November 19, 2024 03:31
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 22, 2024
Related to milvus-io#37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Nov 24, 2024
Related to #37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 25, 2024
Related to milvus-io#37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
congqixia added a commit to congqixia/milvus that referenced this pull request Nov 25, 2024
Related to milvus-io#37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
sre-ci-robot pushed a commit that referenced this pull request Nov 26, 2024
Related to #37768

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
Related to milvus-io#37768

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
Related to milvus-io#37768

---------

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XXL Denotes a PR that changes 1000+ lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants