-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enhance: [GoSDK] Use generic column base and add unit tests #37768
enhance: [GoSDK] Use generic column base and add unit tests #37768
Conversation
Related to milvus-io#31293 Previous column is written using go before 1.18, which does not support generic type. After migrating client pkg to main repo, generic base could be used to reduce lots of duplicated code. Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@congqixia go-sdk check failed, comment |
@congqixia cpp-unit-test check failed, comment |
@congqixia go-sdk check failed, comment |
Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@congqixia cpp-unit-test check failed, comment |
rerun cpp-unit-test |
@congqixia cpp-unit-test check failed, comment |
rerun cpp-unit-test |
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #37768 +/- ##
==========================================
+ Coverage 80.68% 81.03% +0.34%
==========================================
Files 1357 1356 -1
Lines 190831 189836 -995
==========================================
- Hits 153974 153826 -148
+ Misses 31436 30565 -871
- Partials 5421 5445 +24
|
@congqixia E2e jenkins job failed, comment |
/run-cpu-e2e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Related to milvus-io#37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to milvus-io#37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to #37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to milvus-io#37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to milvus-io#37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to #37768 --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to milvus-io#37768 Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to milvus-io#37768 --------- Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
Related to #31293
Previous column is written using go before 1.18, which does not support generic type. After migrating client pkg to main repo, generic base could be used to reduce lots of duplicated code.