Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: some missing metrics for WebUI restful API #37747

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

jaime0815
Copy link
Contributor

issue: #36621

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 17, 2024
Copy link
Contributor

mergify bot commented Nov 17, 2024

@jaime0815

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

Copy link
Contributor

mergify bot commented Nov 17, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.66%. Comparing base (257ecab) to head (6ce9a7f).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37747      +/-   ##
==========================================
- Coverage   80.68%   80.66%   -0.02%     
==========================================
  Files        1357     1357              
  Lines      190750   190780      +30     
==========================================
- Hits       153910   153902       -8     
- Misses      31415    31445      +30     
- Partials     5425     5433       +8     
Components Coverage Δ
Client 61.25% <ø> (ø)
Core 68.87% <ø> (ø)
Go 83.19% <100.00%> (-0.03%) ⬇️
Files with missing lines Coverage Δ
internal/proxy/http_req_impl.go 69.20% <100.00%> (+2.88%) ⬆️
internal/proxy/impl.go 85.06% <100.00%> (ø)
internal/rootcoord/list_db_task.go 100.00% <100.00%> (ø)
pkg/util/metricsinfo/metrics_info.go 100.00% <ø> (ø)

... and 24 files with indirect coverage changes

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 17, 2024

@jaime0815 E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@jaime0815
Copy link
Contributor Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label Nov 17, 2024
@SimFG
Copy link
Contributor

SimFG commented Nov 18, 2024

/lgtm

Signed-off-by: jaime <yun.zhang@zilliz.com>
@SimFG
Copy link
Contributor

SimFG commented Nov 18, 2024

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jaime0815 jaime0815 added this to the 2.5.0 milestone Nov 18, 2024
@sre-ci-robot sre-ci-robot merged commit 12ed40e into milvus-io:master Nov 18, 2024
19 of 20 checks passed
@jaime0815 jaime0815 deleted the webui-fix-db-id branch November 18, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants