Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close leaked health check kafka producer #37728

Merged

Conversation

congqixia
Copy link
Contributor

Related to #36822

Related to milvus-io#36822

Signed-off-by: Congqi Xia <congqi.xia@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/XS Denotes a PR that changes 0-9 lines. labels Nov 15, 2024
@sre-ci-robot sre-ci-robot requested review from xige-16 and yhmo November 15, 2024 10:53
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 15, 2024
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.91%. Comparing base (e4b6773) to head (b82c6ad).
Report is 9 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (e4b6773) and HEAD (b82c6ad). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (e4b6773) HEAD (b82c6ad)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37728       +/-   ##
===========================================
- Coverage   80.66%   68.91%   -11.76%     
===========================================
  Files        1357      290     -1067     
  Lines      190714    25470   -165244     
===========================================
- Hits       153843    17553   -136290     
+ Misses      31438     7917    -23521     
+ Partials     5433        0     -5433     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.91% <ø> (ø)
Go ∅ <ø> (∅)

see 1067 files with indirect coverage changes

@mergify mergify bot added the ci-passed label Nov 15, 2024
@czs007 czs007 added the PR | need cherry-pick need cherry pick to other branches label Nov 16, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 16, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 4820dd7 into milvus-io:master Nov 16, 2024
18 of 20 checks passed
@congqixia
Copy link
Contributor Author

only on master branch

@congqixia congqixia removed the PR | need cherry-pick need cherry pick to other branches label Nov 18, 2024
@congqixia congqixia deleted the fix/close_healthcheck_kafkaproducer branch November 18, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants