Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bm25 brute force search need index params k1 and b #37721

Merged
merged 2 commits into from
Nov 18, 2024

Conversation

aoiasd
Copy link
Contributor

@aoiasd aoiasd commented Nov 15, 2024

relate: #35853

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 15, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 15, 2024
@aoiasd aoiasd force-pushed the doc-in-fix1 branch 2 times, most recently from 244404d to aa58b5e Compare November 15, 2024 09:27
Copy link
Contributor

mergify bot commented Nov 15, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Nov 15, 2024
Copy link
Contributor

mergify bot commented Nov 15, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 15, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link

codecov bot commented Nov 15, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 80.65%. Comparing base (00edec2) to head (d778d31).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/query/SearchBruteForce.cpp 42.85% 4 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 50.00% 2 Missing ⚠️
internal/core/src/query/SearchOnGrowing.cpp 66.66% 1 Missing ⚠️
internal/core/src/segcore/FieldIndexing.h 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37721       +/-   ##
===========================================
+ Coverage   68.91%   80.65%   +11.74%     
===========================================
  Files         290     1357     +1067     
  Lines       25471   190766   +165295     
===========================================
+ Hits        17553   153863   +136310     
- Misses       7918    31466    +23548     
- Partials        0     5437     +5437     
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.85% <47.82%> (-0.07%) ⬇️
Go 83.18% <ø> (∅)
Files with missing lines Coverage Δ
internal/core/src/query/SearchOnSealed.cpp 100.00% <100.00%> (ø)
internal/core/src/query/SearchOnGrowing.cpp 97.56% <66.66%> (-1.18%) ⬇️
internal/core/src/segcore/FieldIndexing.h 65.38% <0.00%> (-0.64%) ⬇️
internal/core/src/segcore/SegmentSealedImpl.cpp 85.75% <50.00%> (-0.14%) ⬇️
internal/core/src/query/SearchBruteForce.cpp 79.06% <42.85%> (-2.54%) ⬇️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 20.48% <0.00%> (-0.08%) ⬇️

... and 1069 files with indirect coverage changes

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 17, 2024

cpp-unit-test

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 17, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 17, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@sre-ci-robot sre-ci-robot removed the size/L Denotes a PR that changes 100-499 lines. label Nov 18, 2024
Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 18, 2024
Copy link
Contributor

mergify bot commented Nov 18, 2024

@aoiasd E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 18, 2024

@aoiasd go-sdk check failed, comment rerun go-sdk can trigger the job again.

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 18, 2024

rerun go-sdk

@aoiasd
Copy link
Contributor Author

aoiasd commented Nov 18, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 18, 2024

@aoiasd cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Signed-off-by: aoiasd <zhicheng.yue@zilliz.com>
@czs007
Copy link
Collaborator

czs007 commented Nov 18, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aoiasd, czs007

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit e9391ac into milvus-io:master Nov 18, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants