Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Correct varchar primarykey size calculation #37617

Merged
merged 5 commits into from
Nov 14, 2024
Merged

fix: Correct varchar primarykey size calculation #37617

merged 5 commits into from
Nov 14, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #37582

@XuanYang-cn
fix: Correct varchar primarykey size calculation
594bfd4 
See also: milvus-io#37582

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/S Denotes a PR that changes 10-29 lines. label Nov 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 12, 2024
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Nov 12, 2024
@XuanYang-cn
fix: [cp24]Correct varchar primarykey size calculation
86ab1ed 
See also: milvus-io#37582
pr: milvus-io#37617

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this pull request Nov 12, 2024
Merged
@codecov Codecov
Copy link

codecov bot commented Nov 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.57%. Comparing base (cf883b1) to head (20d7e8c).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37617       +/-   ##
===========================================
+ Coverage   68.07%   80.57%   +12.50%     
===========================================
  Files         290     1357     +1067     
  Lines       25455   190430   +164975     
===========================================
+ Hits        17328   153446   +136118     
- Misses       8127    31577    +23450     
- Partials        0     5407     +5407
Components Coverage Δ
Client 61.25% <ø> (∅)
Core 68.07% <ø> (ø)
Go 83.21% <100.00%> (∅)
Files with missing lines Coverage Δ
internal/storage/primary_key.go 71.58% <100.00%> (ø)

... and 1066 files with indirect coverage changes

@xiaofan-luan
Copy link
Collaborator

/lgtm
/approve

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 13, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun cpp-unit-test

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@XuanYang-cn go-sdk check failed, comment rerun go-sdk can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 13, 2024

@XuanYang-cn cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

@XuanYang-cn
Copy link
Contributor Author

rerun go-sdk

@XuanYang-cn
Copy link
Contributor Author

rerun cpp-unit-test

@mergify mergify bot added the ci-passed label Nov 14, 2024
congqixia
congqixia approved these changes Nov 14, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, xiaofan-luan, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [congqixia,xiaofan-luan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 31a8d08 into milvus-io:master Nov 14, 2024
20 checks passed
sre-ci-robot pushed a commit that referenced this pull request Nov 14, 2024
@XuanYang-cn
fix: [cp24]Correct varchar primarykey size calculation (#37619)
d23da2d 
See also: #37582
pr: #37617

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@xiaofan-luan xiaofan-luan

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/S Denotes a PR that changes 10-29 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@XuanYang-cn @xiaofan-luan @sre-ci-robot @congqixia