-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: config file validator missed the file tail validation #37608
Conversation
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
@tedxu go-sdk check failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37608 +/- ##
==========================================
- Coverage 68.15% 68.08% -0.08%
==========================================
Files 290 290
Lines 25392 25902 +510
==========================================
+ Hits 17306 17635 +329
- Misses 8086 8267 +181
|
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
7347152
to
a6c459a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See: #32168