Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: config file validator missed the file tail validation #37608

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

tedxu
Copy link
Contributor

@tedxu tedxu commented Nov 12, 2024

See: #32168

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 12, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 12, 2024
Copy link
Contributor

mergify bot commented Nov 12, 2024

@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented Nov 12, 2024

@tedxu go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.08%. Comparing base (2630717) to head (a6c459a).
Report is 9 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37608      +/-   ##
==========================================
- Coverage   68.15%   68.08%   -0.08%     
==========================================
  Files         290      290              
  Lines       25392    25902     +510     
==========================================
+ Hits        17306    17635     +329     
- Misses       8086     8267     +181     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.08% <ø> (-0.08%) ⬇️
Go ∅ <ø> (∅)

see 8 files with indirect coverage changes

Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Copy link
Contributor

@foxspy foxspy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, tedxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit a9538f6 into milvus-io:master Nov 13, 2024
17 of 20 checks passed
@tedxu tedxu deleted the fix/config_test branch November 13, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants