fix: refuse schedule compaction tasks if there is no slot #37589
Conversation
mergify
bot
added
dco-passed
|
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37589 +/- ##
==========================================
- Coverage 68.15% 68.13% -0.02%
==========================================
Files 290 290
Lines 25392 25392
==========================================
- Hits 17306 17302 -4
- Misses 8086 8090 +4
|
|
@tedxu E2e jenkins job failed, comment |
tedxu
force-pushed
the
fix/refuse_schedule_no_slot
branch
from
202b425 to
5226483
Compare
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
tedxu
force-pushed
the
fix/refuse_schedule_no_slot
branch
from
5226483 to
88e8a19
Compare
|
@tedxu cpp-unit-test check failed, comment |
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
| } | ||
| err := t.SetNodeID(nodeID) | ||
| if err != nil { | ||
| log.Info("compactionHandler assignNodeID failed", |
There was a problem hiding this comment.
Please change log level to Warning
There was a problem hiding this comment.
This is copied from previous impl, will change it later.
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
…37589) See milvus-io#37621 --------- Signed-off-by: Ted Xu <ted.xu@zilliz.com>
…37589) See milvus-io#37621 --------- Signed-off-by: Ted Xu <ted.xu@zilliz.com>
See #37621 pr: #37589 --------- Signed-off-by: Ted Xu <ted.xu@zilliz.com> Signed-off-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Signed-off-by: yangxuan <xuan.yang@zilliz.com> Signed-off-by: Wei Liu <wei.liu@zilliz.com> Co-authored-by: Yinzuo Jiang <jiangyinzuo@foxmail.com> Co-authored-by: yangxuan <xuan.yang@zilliz.com> Co-authored-by: wei liu <wei.liu@zilliz.com>
See #37621