Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make NewDataSyncService idempotent of dispatcher #37576

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 11, 2024

issue: #37547

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Nov 11, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Nov 11, 2024
Copy link
Contributor

mergify bot commented Nov 11, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (2630717) to head (ee1cfa2).
Report is 2 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37576      +/-   ##
==========================================
- Coverage   68.15%   68.13%   -0.02%     
==========================================
  Files         290      290              
  Lines       25392    25392              
==========================================
- Hits        17306    17302       -4     
- Misses       8086     8090       +4     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (-0.02%) ⬇️
Go ∅ <ø> (∅)

see 1 file with indirect coverage changes

@chyezh
Copy link
Contributor Author

chyezh commented Nov 11, 2024

/run-cpu-e2e

@bigsheeper
Copy link
Contributor

/lgtm

Copy link
Contributor

mergify bot commented Nov 11, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 11, 2024

/run-cpu-e2e

3 similar comments
@chyezh
Copy link
Contributor Author

chyezh commented Nov 11, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 12, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 12, 2024

/run-cpu-e2e

@chyezh chyezh force-pushed the fix_new_data_sync_service_panic branch from e689cd4 to ca1272c Compare November 12, 2024 06:05
@sre-ci-robot
Copy link
Contributor

New changes are detected. LGTM label has been removed.

@sre-ci-robot sre-ci-robot removed the lgtm label Nov 12, 2024
@chyezh chyezh force-pushed the fix_new_data_sync_service_panic branch from ca1272c to 189d234 Compare November 12, 2024 07:31
@sre-ci-robot sre-ci-robot added the area/dependency Pull requests that update a dependency file label Nov 12, 2024
@mergify mergify bot added the ci-passed label Nov 12, 2024
Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the fix_new_data_sync_service_panic branch from 189d234 to ee1cfa2 Compare November 12, 2024 09:55
@mergify mergify bot removed the ci-passed label Nov 12, 2024
@chyezh
Copy link
Contributor Author

chyezh commented Nov 12, 2024

rerun ut

@mergify mergify bot added the ci-passed label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants