-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: make NewDataSyncService idempotent of dispatcher #37576
base: master
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chyezh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@chyezh E2e jenkins job failed, comment |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #37576 +/- ##
==========================================
- Coverage 68.15% 68.13% -0.02%
==========================================
Files 290 290
Lines 25392 25392
==========================================
- Hits 17306 17302 -4
- Misses 8086 8090 +4
|
/run-cpu-e2e |
/lgtm |
@chyezh E2e jenkins job failed, comment |
/run-cpu-e2e |
3 similar comments
/run-cpu-e2e |
/run-cpu-e2e |
/run-cpu-e2e |
e689cd4
to
ca1272c
Compare
New changes are detected. LGTM label has been removed. |
ca1272c
to
189d234
Compare
Signed-off-by: chyezh <chyezh@outlook.com>
189d234
to
ee1cfa2
Compare
rerun ut |
issue: #37547