Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix large growing segment (#37388) #37540

Merged
merged 1 commit into from
Nov 8, 2024
Merged

fix: Fix large growing segment (#37388) #37540

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion internal/datacoord/segment_allocation_policy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,18 @@ func AllocatePolicyL1(segments []*SegmentInfo, count int64,
for _, allocation := range segment.allocations {
allocSize += allocation.NumOfRows
}
free := segment.GetMaxRowNum() - segment.GetNumOfRows() - allocSize

// When inserts are too fast, hardTimeTick may lag, causing segment to be unable to seal in time.
// To prevent allocating large segment, introducing the sealProportion factor here.
// The condition `free < 0` ensures that the allocation exceeds the minimum sealable size,
// preventing segments from remaining unsealable indefinitely.
maxRowsWithSealProportion := int64(float64(segment.GetMaxRowNum()) * paramtable.Get().DataCoordCfg.SegmentSealProportion.GetAsFloat())
free := maxRowsWithSealProportion - segment.GetNumOfRows() - allocSize
if free < 0 {
continue
}

free = segment.GetMaxRowNum() - segment.GetNumOfRows() - allocSize
if free < count {
continue
}
Expand Down
Loading