Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: use localhost for it and ut #37529

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Nov 8, 2024

issue: #37528

Signed-off-by: chyezh <chyezh@outlook.com>
@sre-ci-robot sre-ci-robot added area/test size/S Denotes a PR that changes 10-29 lines. sig/testing test/integration integration test labels Nov 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 8, 2024
Copy link
Contributor

mergify bot commented Nov 8, 2024

@chyezh go-sdk check failed, comment rerun go-sdk can trigger the job again.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (bc9562f) to head (5aaa469).
Report is 34 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37529      +/-   ##
==========================================
+ Coverage   82.50%   82.53%   +0.03%     
==========================================
  Files        1064     1066       +2     
  Lines      163530   163738     +208     
==========================================
+ Hits       134917   135141     +224     
+ Misses      23268    23242      -26     
- Partials     5345     5355      +10     
Components Coverage Δ
Client 60.27% <ø> (ø)
Core ∅ <ø> (∅)
Go 83.26% <79.36%> (+0.03%) ⬆️
Files with missing lines Coverage Δ
tests/integration/minicluster_v2.go 70.12% <100.00%> (+0.60%) ⬆️

... and 34 files with indirect coverage changes

Copy link
Contributor

mergify bot commented Nov 8, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 8, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 8, 2024

rerun go-sdk

Copy link
Contributor

mergify bot commented Nov 8, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 8, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 8, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@chyezh
Copy link
Contributor Author

chyezh commented Nov 9, 2024

/run-cpu-e2e

1 similar comment
@chyezh
Copy link
Contributor Author

chyezh commented Nov 11, 2024

/run-cpu-e2e

@chyezh
Copy link
Contributor Author

chyezh commented Nov 11, 2024

also see: #37397

@yanliang567 yanliang567 added ci-passed manual-pass manually set pass before ci-passed labeled labels Nov 12, 2024
@chyezh chyezh added the lgtm label Nov 12, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: chyezh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit b5b0035 into milvus-io:master Nov 12, 2024
19 checks passed
@chyezh chyezh deleted the fix_use_local_port_for_ut branch November 12, 2024 03:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled sig/testing size/S Denotes a PR that changes 10-29 lines. test/integration integration test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants