Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce tiny compaction to reduce compaction cost #37520

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

xiaofan-luan
Copy link
Collaborator

fix #37519

Signed-off-by: xiaofanluan <xiaofan.luan@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added approved size/M Denotes a PR that changes 30-99 lines. labels Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@xiaofan-luan

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@xiaofan-luan xiaofan-luan changed the title feature: introduce tiny compaction to reduce compaction cost feat: introduce tiny compaction to reduce compaction cost Nov 7, 2024
@mergify mergify bot added the kind/feature Issues related to feature request from users label Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@xiaofan-luan E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.13%. Comparing base (40ba5a3) to head (be900fd).
Report is 3 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (40ba5a3) and HEAD (be900fd). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (40ba5a3) HEAD (be900fd)
2 1
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #37520       +/-   ##
===========================================
- Coverage   80.62%   68.13%   -12.50%     
===========================================
  Files        1333      290     -1043     
  Lines      186985    25395   -161590     
===========================================
- Hits       150755    17302   -133453     
+ Misses      30949     8093    -22856     
+ Partials     5281        0     -5281     
Components Coverage Δ
Client ∅ <ø> (∅)
Core 68.13% <ø> (ø)
Go ∅ <ø> (∅)

see 1043 files with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/feature Issues related to feature request from users size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Introduce tiny compaction to accelerate small segment merge
2 participants