Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: support null in text match index #37517

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

smellthemoon
Copy link
Contributor

@sre-ci-robot sre-ci-robot added the size/XL Denotes a PR that changes 500-999 lines. label Nov 7, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 7, 2024
Copy link
Contributor

mergify bot commented Nov 7, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 7, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

@smellthemoon
Copy link
Contributor Author

rerun cpp-unit-test

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented Nov 8, 2024

Codecov Report

Attention: Patch coverage is 43.58974% with 44 lines in your changes missing coverage. Please review.

Project coverage is 80.56%. Comparing base (1b6edd0) to head (3875510).
Report is 21 commits behind head on master.

Files with missing lines Patch % Lines
internal/core/src/index/TextMatchIndex.cpp 34.04% 31 Missing ⚠️
internal/core/src/exec/expression/Expr.h 63.15% 7 Missing ⚠️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 0.00% 4 Missing ⚠️
internal/core/src/segcore/SegmentSealedImpl.cpp 50.00% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37517      +/-   ##
==========================================
+ Coverage   80.55%   80.56%   +0.01%     
==========================================
  Files        1356     1356              
  Lines      190059   190122      +63     
==========================================
+ Hits       153102   153172      +70     
- Misses      31526    31536      +10     
+ Partials     5431     5414      -17     
Components Coverage Δ
Client 60.27% <ø> (ø)
Core 68.06% <43.58%> (-0.07%) ⬇️
Go 83.22% <ø> (+0.02%) ⬆️
Files with missing lines Coverage Δ
internal/core/src/segcore/SegmentGrowingImpl.cpp 77.60% <100.00%> (+0.11%) ⬆️
internal/core/src/segcore/SegmentGrowingImpl.h 70.00% <ø> (ø)
internal/core/src/segcore/SegmentSealedImpl.cpp 85.94% <50.00%> (+0.01%) ⬆️
...rnal/core/src/segcore/ChunkedSegmentSealedImpl.cpp 14.85% <0.00%> (-0.02%) ⬇️
internal/core/src/exec/expression/Expr.h 74.02% <63.15%> (-1.06%) ⬇️
internal/core/src/index/TextMatchIndex.cpp 41.66% <34.04%> (-3.87%) ⬇️

... and 27 files with indirect coverage changes

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 8, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@smellthemoon
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon cpp-unit-test check failed, comment rerun cpp-unit-test can trigger the job again.

Copy link
Contributor

mergify bot commented Nov 11, 2024

@smellthemoon E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: lixinguo <xinguo.li@zilliz.com>
@sunby
Copy link
Contributor

sunby commented Nov 12, 2024

/lgtm

Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, smellthemoon

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 3389a6b into milvus-io:master Nov 13, 2024
18 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XL Denotes a PR that changes 500-999 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants